MightyMoud / sidekick

Bare metal to production ready in mins; your own fly server on your VPS.
https://www.sidekickdeploy.com
GNU General Public License v3.0
5.94k stars 96 forks source link

Docker compose files on deploy does not have restart property #62

Open dejanstrancar opened 1 week ago

dejanstrancar commented 1 week ago

When using Sidekick v.0.6.6 installed with brew generated docker-compose.yml file does include restart property. (restart: unless-stopped).

When doing it on same app from the github code source, it does include it.

Recreation:

Dockerfile

FROM node:20
WORKDIR /app
EXPOSE 3000

Brew installed sidekick v.0.6.6 version: sidekick launch

Generated docker-compose.yml:

services:
    testing:
        image: testing
        labels:
            - traefik.enable=true
            - traefik.http.routers.testing.rule=Host(`testing.167.99.243.82.sslip.io`)
            - traefik.http.services.testing.loadbalancer.server.port=3000
            - traefik.http.routers.testing.tls=true
            - traefik.http.routers.testing.tls.certresolver=default
            - traefik.docker.network=sidekick
        networks:
            - sidekick
networks:
    sidekick:
        external: true

Github source running from source:

sidekick launch

Generated docker-compose.yml:

services:
    testing:
        image: testing
        restart: unless-stopped
        labels:
            - traefik.enable=true
            - traefik.http.routers.testing.rule=Host(`testing.167.99.243.82.sslip.io`)
            - traefik.http.services.testing.loadbalancer.server.port=3000
            - traefik.http.routers.testing.tls=true
            - traefik.http.routers.testing.tls.certresolver=default
            - traefik.docker.network=sidekick
        networks:
            - sidekick
networks:
    sidekick:
        external: true

Homebrew: 4.4.4 Sidekick: v0.6.6

zeornelas commented 1 day ago

Not sure if related with this issue but whenever the VPS restarts the containers are not being launched. If you have automatic maintenance on your VPS this can be problematic. @MightyMoud Should I open another issue for this bug/feature request?