MightyPirates / OpenComputers

Home of the OpenComputers mod for Minecraft.
https://oc.cil.li
Other
1.58k stars 429 forks source link

Robots cause water to flow around them even after leaving #2605

Closed InfinitiesLoop closed 6 years ago

InfinitiesLoop commented 6 years ago

When a robot steps into water, water flows around it, as expected. But after leaving, the water remains. This can cause a single source block of water (or lava) to extend flowing blocks in every direction if the robot walks through the water in those directions. There are cases where these interact with other existing source blocks to create new source blocks. I have had a single source block cause flowing water blocks to fill a 25x25x50 area because of this. The main time you run into it is when a robot digs a quarry. It walks through the water or lava that happens to be in the way, spreading it more and more each time it goes through it.

Here's a sequence of screenshots that show it in action.

I suppose it is because the robot is not causing an 'update' to trigger from the block it came from, so the water doesn't know it needs to update its flowing state? Wild guess.

2017-10-28_19 21 17 2017-10-28_19 21 51 2017-10-28_19 22 12

0f-0b commented 6 years ago

Vanilla Minecraft bug

simonmeusel commented 6 years ago

Yes, if you would place and then remove dirt where your robot moves along, it would result in exactly the same result

InfinitiesLoop commented 6 years ago

Hmmm. Ok, but that hopefully doesn’t mean oc can’t work around it. Water doesn’t do that when an entity like a player or mob enters it, so why should it for a robot? Perhaps it’s registering as a block and not an entity?

InfinitiesLoop commented 6 years ago

More than a minor annoyance. When my bot digs a quarry unattended for a long time, it can cause so much flowing water and lava to appear that the client lags animating it, and cleaning it up is extremely difficult.

simonmeusel commented 6 years ago

Since robots are actually blocks (that's intended), it would be hard to work around it. But you can use drones, which are entities, and those won't disturb the water

simonmeusel commented 6 years ago

Actually drones will shut down if they are in fluids ...

payonel commented 6 years ago

tbh, this almost feels like a feature request.

simonmeusel commented 6 years ago

Drones being able to go through water? Maybe with an upgrade.

But water somehow ignoring the robots would probably break many mob farms, which use water.

payonel commented 6 years ago

yeah, this is based on some vanilla mechanics of water generation