Closed Sturmlilie closed 3 years ago
Now that 1.16.1 is out, are there any plans to get this up to date and working?
@iamgreaser check here: https://github.com/Sturmlilie/TIS-3D/releases/tag/1.16-ALPHA If you could playtest and report any bugs that would be immensely helpful!
Sorry again for the long wait. Having a look now!
Created master-MC1.16-fabric
for the PR.
Intermediate update:
Btw, really like the new addStringListToTooltip implementation!
Awesome, thanks again for the valuable feedback :) I just tested the current branch on dedicated and couldn't make out any obvious issues, so I think this is good to merge. I'll shortly make a PR fixing whatever broke two snapshots ago so a 1.16.2 release can happen without too much delay.
Marginal changes compared to 1.15 port. Overview:
Screen
andAbstractButton
subclass now takes aMatrixStack
as the first parameter to#render
. This however doesn't affect most of the rendering code itself, only native methods like those ofTextRenderer
andDrawableHelper
need the stack passed through.StringRenderable
(which is also a super-interface ofText
). See [1].[1] Unfortunately, tooltips still want a
List<Text>
which the text wrapping functions ofTextHandler
don't directly provide anymore (seeWIP:
commit), but this can be worked around by supplying a customLineWrappingConsumer
callback-impl that would create the appropriate line objects.[2] I've tried for the longest time to wrap my head around how to properly reinstall the dimension id that is sent with each location-based update message, but after lots of failed attempts and a few conversations on Fabricord, I decided to just cut that code completely. I'm a bit anxious about it because I don't know what kind of problem the original code was solving. So far I've done some base-level testing on both integrated and dedicated server and things seem to work fine.
v2: Squashed all build-fixing commits into one, every commit should (hopefully) build now.
Works without changes up to
20w30a20w29a. In 30a, changes to the text rendering cause the manual GUI code to crash.Questions:
FontRendererUtils
a good decision?World
?