MightyPirates / TIS-3D

TIS-100 inspired low-tech computing in Minecraft.
https://www.curseforge.com/minecraft/mc-mods/tis-3d
Other
105 stars 35 forks source link

Casings don't support rotation #153

Open AnFazer opened 2 years ago

AnFazer commented 2 years ago

I've stumbled upon this issue by accident, while studying how TIS-3D works on moving contraptions from Create, but given its severity and apparent obviousness, I'm very surprised it had never been reported before.

Version: 1.6.8 (MC 1.16)

Problem: As stated, casing blocks don't allow themselves to be rotated, as opposed to almost all other direction-dependent blocks from both vanilla and modded Minecraft: stairs, chests, torches, mod-added machines of all kinds, just to name a few.

Reproducing: Put a module inside a casing block, try to rotate it using any of the available means (Mechanical bearing from Create, Turntable from Supplementaries, any mod that allows you to copy/move structures or import schematics while rotating them (WorldEdit, Create), wrenches of all kinds, etc.) and observe that no rotation actually happens, all modules remain on their respective sides with their respective orientations.

Why is it a problem: Since most if not all TIS-3D programs inevitably depend on the orientation of modules, failing to properly rotate casings and modules along with the rest of the structure they are a part of disrupts all but the simplest programs and possibly even ejects modules as items, thus severely limiting players' ability to include TIS-3D computers into shareable schematics or moving contraptions (for example trains, flying machines or certain types of farms).

AnFazer commented 2 years ago

I hope this helps. TIS-3D is such a wonderful mod - with limitless creative applications, yet balanced and fun to work with - and I would really love for the technically-inclined players' community to become more aware of it, especially now that it's yet again available for Forge (something I've discovered only recently by pure accident and was extremely and pleasantly surprised, to say the least). Thank you so much for your amazing work! <3

fnuecke commented 2 years ago

Thanks for the kind words :)

Interesting point. I'm assuming this would need to support block rotation on BlockState level for these integrations to properly work? This will be a little... interesting to add. But I agree, should be supported.