Why custom raycast when it is allready implemented in mc

MightyPirates / TIS-3D

TIS-100 inspired low-tech computing in Minecraft.

https://www.curseforge.com/minecraft/mc-mods/tis-3d

Other

109 stars 35 forks source link

Why custom raycast when it is allready implemented in mc #174

Closed walksanatora closed 1 year ago

walksanatora commented 1 year ago

Yes another question while fixing ValkrienSkies conpat (as my sanity dwindles yet more)

fnuecke commented 1 year ago

Presumably because this didn't exist back when it was originally implemented (at least not in the way it was needed). A PR to switch to the built-in logic while preserving current behavior is welcome!

walksanatora commented 1 year ago

huh i have a mixin just for this (i converted your raycast to a mixin for VS2 so that Infared Packets could work on ships)

walksanatora commented 1 year ago

all i had to do was create a custom ClipContext and overrde getBlockShape what i ended up doing was getting a Boolean AND of the block collision + Visual shape