search

MightyPirates / TIS-3D

TIS-100 inspired low-tech computing in Minecraft.
https://www.curseforge.com/minecraft/mc-mods/tis-3d
Other
108 stars 35 forks source link

TIS-3D registers its textures to just every existing texture map without checking whether it's the correct one. #94

Closed CD4017BE closed 5 years ago

CD4017BE commented 5 years ago

see: MightyPirates/OpenComputers#3094

asiekierka commented 5 years ago

There's quite a lot of mods doing this, mind, and I don't blame them - this is only properly accounted for by vanilla in 1.14.

CD4017BE commented 5 years ago

this is only properly accounted for by vanilla in 1.14

No, it's rather that vanilla on its own doesn't use more than one TextureMap instance, so some modders blindly assume that the TextureMap given in the TextureStitchEvent is always the blocks texture map.

CD4017BE commented 5 years ago

Ok, I think getting this fixed by other mods is hopeless:

[17:04:34] [Client thread/FATAL] [rs_ctr]: The following mods attempted to register textures into a texture atlas they don't belong:
- cofh
- industrialforegoing
- buildcraftlib
- powersuits
- immersiveengineering
- thermaldynamics
- buildcraftsilicon
- buildcraftenergy
- buildcrafttransport
- genetics
- bibliocraft
- thermalfoundation
- ic2
- buildcraftbuilders
- reborncore
- topaddons
- buildcraftfactory
- appliedenergistics2
- blockcraftery
- ae2stuff
- railcraft
- thermalexpansion
- xreliquary
- buildcraftcompat
- chisel
- computercraft
- ftblib
- flatcoloredblocks
- thaumcraft
- peripheralsplusone
- forge
- mysticallib
- twilightforest
- chiselsandbits
- buildcraftcore
- techreborn
- magicbees
- forestry
- extratrees
Modders please check whether the TextureMap given in texture stitch event is actually the one you want to register to!
asiekierka commented 5 years ago

No, it's rather that vanilla on its own doesn't use more than one TextureMap instance, so some modders blindly assume that the TextureMap given in the TextureStitchEvent is always the blocks texture map.

Because that is the case in vanilla.

Really, just, make your own stitch, event, and block Forge's from emitting