search

MightyPork / TinyFrame

A simple library for building and parsing data frames for serial interfaces (like UART / RS232)
MIT License
344 stars 111 forks source link

add timeout callback for the Listener #23

Closed loveshipting closed 2 years ago

loveshipting commented 2 years ago

add timeout callback for the Listener

MightyPork commented 2 years ago

Hi, looks good, please correct the formatting (space before comma in the argument lists) and add a NULL check before the timeout callback is run (and a better name than "of"? what does "of" mean?). The timeout callback will be NULL when unused.

loveshipting commented 2 years ago

Check, please. By the way, the compiling is OK, but My local format is not match yours, if may not match yours, sorry. And What kind of formatting code tool you use?

MightyPork commented 2 years ago

Thanks, it's merged (github is confused, because I did it from the command line, I think?). I will close this now.

Added some small fixes. The formatting was done with CLion.