MiguelCastillo / Brackets-InteractiveLinter

Interactive linting for Brackets
Other
119 stars 26 forks source link

Linter does not work #159

Open spietrek opened 9 years ago

spietrek commented 9 years ago

I am having an issue where the linter extension does not work. I have JSCS and JSHint loaded. The linter will work only occasionally. Generally, I need to restart Brackets a bunch of times with and without extensions in order for it to activate.

"language": { "javascript": { "linting.prefer": [ "JSHint", "JSCS" ], "linting.usePreferredOnly": true } }, "interactive-linter.javascript": [ "jscs", "jshint" ], "interactive-linter.delay": 1000, "interactive-linter.html": [ "htmlhint" ],

The other extensions I have loaded include:

  1. AngularJS Code Hints
  2. Brackets Beautify
  3. Brackets Bower
  4. Brackets Commands Quick Search
  5. Brackets Css Color Preview
  6. Brackets Dash
  7. Brackets Git
  8. Brackets Icons
  9. Ceratrior II theme
  10. Duplicate Files & Folders
  11. Extensions Rating
  12. File Tree Exclude
  13. HTML Block Selector
  14. Indent Guides
  15. Interactive Linter
  16. Markdown Preview
  17. Minifier
  18. Minimap
  19. Paste & Indent
  20. Select Lines
  21. Tabs - Custom Working
  22. Whitespace Normalizer

What should I look out for to determine why the extension is not working? Anything I should be aware of?

Thanks

-Steve

iegik commented 8 years ago

conflicts with brackets-git

MiguelCastillo commented 8 years ago

@spietrek Sorry about that. Have you tried switching the order your linter definition to:

"interactive-linter.javascript": [
"jshint",
"jscs"
]

Interactive linter only supports one linter, even though the definition is an array. Array definition is just thinking ahead of features I would like to add and have not had to time to.

@iegik I am interested in what you said here. Is there a known conflict, something you have ran into, or just a guess?

spietrek commented 8 years ago

Thanks Miguel. I am also running Brackets Git too.

-Steve Pietrek

On Oct 28, 2015, at 9:59 AM, Miguel Castillo notifications@github.com wrote:

@spietrek Sorry about that. Have you tried switching the order your linter definition to:

"interactive-linter.javascript": [ "jshint", "jscs" ] Interactive linter only supports one linter, even though the definition is an array. Array definition is just thinking ahead of features I would like to add and have not had to time to.

@iegik I am interested in what you said here. Is there a known conflict, something you have ran into, or just a guess?

— Reply to this email directly or view it on GitHub.

MiguelCastillo commented 8 years ago

@spietrek Did you try switching the order of your linter definitions to have jshint first?

iegik commented 8 years ago

@MiguelCastillo I have tried to switch the order of extensions. No effect. Where actually can change extension load order?

MiguelCastillo commented 8 years ago

The actual bit that makes assumptions about there being an array and using the first entry is https://github.com/MiguelCastillo/Brackets-InteractiveLinter/blob/master/linterManager.js#L36

This issue certainly does not seem straight forward, so if you guys could help me diagnose it, that would be awesome.

What environments (OS) are you guys running?

The other thing that is interesting is

"linting.prefer": [
"JSHint",
"JSCS"
],

That's not needed unless you have install the corresponding extensions and not using interactive linter. Interactive linter will override the JS linting in Brackets.

iegik commented 8 years ago

Ubuntu. I have installed both extensions - brackets-git and Brackets-InteractiveLinter. After Git extension is enabled - Brackets-InteractiveLinter do not work. Both extensions uses left side of editor content.

"linting.prefer": []
MiguelCastillo commented 8 years ago

Ohhh, that's interesting (in a bad way). Interactive linter works when brackets-git is not installed? :-/ I gotta look into that soon! Thanks for the info.

spietrek commented 8 years ago

I have seen Interactive Linter not work on OSX. I also have Brackets Git installed. Seems to happen more often after installing or uninstalling other extensions and restarting Brackets. Sometimes takes multiple restarts with and without extensions to get things to work.

-Steve Pietrek

On Nov 1, 2015, at 4:06 PM, Miguel Castillo notifications@github.com wrote:

Ohhh, that's interesting (in a bad way). Interactive linter works when brackets-git is not installed? :-/ I gotta look into that soon! Thanks for the info.

— Reply to this email directly or view it on GitHub.

iegik commented 8 years ago

@MiguelCastillo, @spietrek I have removed all extensions except Git and Linter and switching them on/off, decided, that Linter does not work after Git is enabled.

MiguelCastillo commented 8 years ago

This is really helpful guys. I really don't run into these issues. I will try to repro with git. Thanks!!

iegik commented 8 years ago

Note: Git hightlight row corner then line was changed, but Linter also mark that line, when it is with the error. I think marks are shown there, but they are not visible because Git replace/override them!

jaymascarenas commented 8 years ago

I have found that if you disable the extension and then enable it again the linter starts to work again. This is with brackets-git also installed. Thanks!!