search

MiguelCastillo / Brackets-InteractiveLinter

Interactive linting for Brackets
Other
119 stars 26 forks source link

Redesign inline widgets #83

Closed Mark-Simulacrum closed 9 years ago

Mark-Simulacrum commented 10 years ago

Redesigned inline widgets to better support light and dark themes.

Please take a look, you are probably the better designer. Unfortunately, I cannot easily post a screenshot, since that is quite difficult for me (requires editing in Photoshop/Gimp).

Mark-Simulacrum commented 10 years ago

Light theme: image

Dark theme: image

I think it might be worth it to color the text, but I'm still exploring that option.

Mark-Simulacrum commented 10 years ago

With text coloring: Note: Updating these as I go along.

Light Theme: image

Dark Theme: image

Mark-Simulacrum commented 10 years ago

At this point, I don't think coloring the text is a good idea. We would need different colors for light/dark themes, and I've still not found a good yellow that works on light themes. If you want to experiment, though, feel free to grab this branch and add color properties to the CSS (rules on lines 66 and 67).

MiguelCastillo commented 9 years ago

I really like this! I think that keeping text as either black or white would be better. One thing that we developers tend to overlook is actually color blind people :) The icons are really cool though.

Mark-Simulacrum commented 9 years ago

Yes, the current code keep the text the "default" color for the type of theme; so white for dark themes and black for light themes. I think the exact colors Brackets uses aren't white/black but a little different, but that is the general idea.

MiguelCastillo commented 9 years ago

Yeah that's what I meant :D