search

MiguelCastillo / amd-resolver

Resolve module names to File objects
MIT License
0 stars 1 forks source link

File.parseURI returns object with `search` field, should be `query` field. #13

Closed Mark-Simulacrum closed 9 years ago

Mark-Simulacrum commented 9 years ago

From what I have found on the internet, ?=testing=foo is the query string, not the search string.

MiguelCastillo commented 9 years ago

Yeah query and search are the same thing, right?

Mark-Simulacrum commented 9 years ago

Perhaps - I haven't worked much with URI/URL parsing before. It seems odd to call it the search string, since in some/many cases it has nothing to do with search. I guess it is a matter of opinion though.

MiguelCastillo commented 9 years ago

As far as my opinion goes, it is more a matter of what the browser implements in window.location, which is search.

Mark-Simulacrum commented 9 years ago

I did not know that window.location had search and not query. I see why we use search now.

Thank you for explaining.

MiguelCastillo commented 9 years ago

of course! :)