search

MiguelMedeiros / phoenix-server-js

Phoenix-Server-JS combines promise-based and WebSocket interfaces for developer convenience and efficiency.
https://npmjs.com/package/phoenix-server-js
MIT License
16 stars 3 forks source link

feat: accept `username` as an optional parameter #1

Closed mubarak23 closed 7 months ago

mubarak23 commented 7 months ago

Looking at the code. It is best if we accept both the username and host. This PR allows the user to pass these parameters. This way, the user can decide to change the username and host for the daemon. What do you think?

MiguelMedeiros commented 7 months ago

It's okay to ask for the username, but both username and host should be optional. In this PR, you removed the default values and the optionality of the parameters, which will end up breaking the package compatibility.

mubarak23 commented 7 months ago

I will make both username and host optional, Then