Closed mubarak23 closed 7 months ago
It's okay to ask for the username, but both username
and host
should be optional.
In this PR, you removed the default values and the optionality of the parameters, which will end up breaking the package compatibility.
I will make both username and host optional, Then
Looking at the code. It is best if we accept both the username and host. This PR allows the user to pass these parameters. This way, the user can decide to change the username and host for the daemon. What do you think?