search

MihaMarkic / Cake.Docker

Cake AddIn that extends Cake with Docker
MIT License
47 stars 36 forks source link

DockerComposeUpSettings: Scale is bool instead of string #112

Closed davy-oo closed 1 year ago

davy-oo commented 1 year ago

A regression happened in v 1.2.1, the "Scale" parameter switched from string to bool. It should be string.

Ref https://github.com/MihaMarkic/Cake.Docker/blob/master/src/Cake.Docker/Compose/Up/DockerComposeUpSettings.cs#L107

Version 1.2.0 is correct.

MihaMarkic commented 1 year ago

It should be string again in 1.2.2. Can you check?

dcourvoi commented 1 year ago

it's bool in 1.2.2: https://github.com/MihaMarkic/Cake.Docker/blob/v1.2.2/src/Cake.Docker/Compose/Up/DockerComposeUpSettings.cs#L107

MihaMarkic commented 1 year ago

Fixed in 331b6b36b4bf2edfce9fe24c0c88fd7bec70a137