search

MihaMarkic / Cake.Docker

Cake AddIn that extends Cake with Docker
MIT License
47 stars 36 forks source link

chore: update cake to v1.1.0 #90

Closed sethfduke closed 3 years ago

sethfduke commented 3 years ago

Update Cake packages to v1.1.0.

sethfduke commented 3 years ago

bump

MihaMarkic commented 3 years ago

@sethfduke Hi there, why do we need this? Does it currently not work with 1.1?

sethfduke commented 3 years ago

@sethfduke Hi there, why do we need this? Does it currently not work with 1.1?

It does work without issue with Cake v1.0.0, however it does throw a warning about using such an old version of Cake.Core. Seemed like a logical fix to just bump the version.

The assembly 'Cake.Docker, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' 
is referencing an older version of Cake.Core (0.33.0). 
For best compatibility it should target Cake.Core version 1.0.0.
MihaMarkic commented 3 years ago

@sethfduke Are you sure that you are using the latest Cake.Docker 1.0.0. It references Cake.Core 1.0.0, not 0.33.0 as your warning says.

sethfduke commented 3 years ago

@sethfduke Are you sure that you are using the latest Cake.Docker 1.0.0. It references Cake.Core 1.0.0, not 0.33.0 as your warning says.

Ah, I see now, there was a second addin line in one of our Cake files that was using the older version still. My apologies.

MihaMarkic commented 3 years ago

@sethfduke Hey, no worries, have fun with Cake.Docker and thanks for creating a PR nevertheless.