MihaelIsaev / FCM

⚡️ PushNotifications through FireBase for Vapor 3 and 4.
MIT License
125 stars 36 forks source link

Make config datamodel equatable and rename FCMApnsAlertOrString helpers #15

Closed FredericRuaudel closed 4 years ago

FredericRuaudel commented 4 years ago

Sorry, it's me again 😬

Should be the last PR I need for now. 🤞

This one make the payload data models Equatable, again to ease tests. To do this, I had to convert some models from class to struct (FCMApnsPayload and FCMApnsApsObject).

Is there a particular reason for using class here or it is simply a default choice?

I also renamed the FCMApnsAlertOrString to asPayload/asMessage as mentioned in the previous one.

Again, thanks very much for your quick reviews.