MihaelIsaev / FCM

⚡️ PushNotifications through FireBase for Vapor 3 and 4.
MIT License
120 stars 33 forks source link

Fix memory issues #26

Closed grahamburgsma closed 3 years ago

grahamburgsma commented 3 years ago

I've fixed the memory issue that I was seeing in #25. I think it had to do with the getData and getBytes usage, but not entirely sure why. To make it easier and simplify the code I switched out HTTPClient for Vapor's Client which is nicer to use. I also generalized the error handing since it differed slightly in multiple places.

You can see here the memory usage is a lot better after sending notifications. Screen Shot 2020-08-11 at 8 25 09 AM