search

MihaelIsaev / FCM

⚡️ PushNotifications through FireBase for Vapor 3 and 4.
MIT License
120 stars 33 forks source link

Feature/improve batch messaging #30

Closed siemensikkema closed 3 years ago

siemensikkema commented 3 years ago

Implements #29

siemensikkema commented 3 years ago

We'll test it more on a project tomorrow. So far it seemed to work well for single notifications sent using the batch method.

siemensikkema commented 3 years ago

Are we sure the limit is 500?

Pretty sure. The documentation mentions a maximum of 500 and this python library also has a limit of 500.

pbodsk commented 3 years ago

But earlier in the same document they mention

You can specify up to 100 device registration tokens (500 for Java and Node.js) per invocation.

But that must be legacy since they also support 500 messages in Python but only mentions Java and Node.js.

MihaelIsaev commented 3 years ago

We'll test it more on a project tomorrow. So far it seemed to work well for single notifications sent using the batch method.

@siemensikkema could you please confirm that you tested it for multiple notifications sent using the batch method and I'll merge and release it. Thank you 🙏

MihaelIsaev commented 3 years ago

@siemensikkema have you had a chance to test it on sending a message to more than one recipient? 🙂

siemensikkema commented 3 years ago

@MihaelIsaev Hi! Thanks for following up! Yes, we've been using this in production for over a week now and there are no complaints from the client anymore ☺️

MihaelIsaev commented 3 years ago

It is now available since 2.9.0 tag! @siemensikkema many thanks for the contribution! 🥳🚀