search

MihaelIsaev / FCM

⚡️ PushNotifications through FireBase for Vapor 3 and 4.
MIT License
125 stars 36 forks source link

Retrieve subscribed topics #43

Closed chinh-tran closed 6 months ago

chinh-tran commented 10 months ago

Retrieves the subscribed topics for a given token as documented here: https://developers.google.com/instance-id/reference/server?hl=en#get_information_about_app_instances

MihaelIsaev commented 6 months ago

@chinh-tran thanks for the contribution!

Screenshot 2024-03-14 at 18 22 16

I guess there should be only one method without underscore. Underscored methods usually expected to be private, but seems there is no need for the second private underscored method. Could you please leave only one public method without underscore and I will merge your pull request. Thanks

chinh-tran commented 6 months ago

@chinh-tran thanks for the contribution!

Screenshot 2024-03-14 at 18 22 16

I guess there should be only one method without underscore. Underscored methods usually expected to be private, but seems there is no need for the second private underscored method. Could you please leave only one public method without underscore and I will merge your pull request. Thanks

@MihaelIsaev Thanks for the feedback! I've updated the code.