Update to JWT3 and simplify

MihaelIsaev / FCM

⚡️ PushNotifications through FireBase for Vapor 3 and 4.

MIT License

120 stars 33 forks source link

Update to JWT3 and simplify #5

Closed siemensikkema closed 5 years ago

siemensikkema commented 5 years ago

Relates to #4

MihaelIsaev commented 5 years ago

@siemensikkema Hey, thank you very much, I just had no time yesterday to make that work.

siemensikkema commented 5 years ago

@MihaelIsaev I hope you agree with the simplifications. My colleague will test it (hopefully) today :)

rasmusebbesen commented 5 years ago

I just tested the changes in @siemensikkema 's fork with no problems. 👍 from me!

MihaelIsaev commented 5 years ago

@siemensikkema do you think that updateIfNeeded() function is ambiguous?

siemensikkema commented 5 years ago

@MihaelIsaev It didn't seem necessary. In getJWT() there is already a check for expired and the only other time you call generateJWT() is right after creating it.

MihaelIsaev commented 5 years ago

@siemensikkema Thanks for that pull request! It's available now in 0.6.0 tag 👍

siemensikkema commented 5 years ago

@MihaelIsaev perfect! thanks! 🙏

rasmusebbesen commented 5 years ago

Awsome.. Thanks!