search

MihaiValentin / lunr-languages

A collection of languages stemmers and stopwords for Lunr Javascript library
Other
430 stars 163 forks source link

Add Hebrew language support #102

Closed avisaradir closed 1 year ago

avisaradir commented 1 year ago

Added Hebrew language support

Change build/build.js to include the newly added language.

Added test cases for Hebrew language.

MihaiValentin commented 1 year ago

Hi @avisaradir , thanks for contributing! It seems the tests are failing: https://app.circleci.com/pipelines/github/MihaiValentin/lunr-languages/75/workflows/196dc78b-5f46-42fc-8d60-e35a0047098c/jobs/124

can you please fix them and I will merge this?

Thanks!

MihaiValentin commented 1 year ago

Thanks. Do all your tests pass correctly on your local machine?

It seems some tests are broken: https://app.circleci.com/pipelines/github/MihaiValentin/lunr-languages/76/workflows/54d0e90b-b759-447a-a1ee-8c459e4f2de6/jobs/125

avisaradir commented 1 year ago

Hi @avisaradir , thanks for contributing! It seems the tests are failing: https://app.circleci.com/pipelines/github/MihaiValentin/lunr-languages/75/workflows/196dc78b-5f46-42fc-8d60-e35a0047098c/jobs/124

can you please fix them and I will merge this?

Thanks!

Just finished fixing the errors, waiting for your approval :)

MihaiValentin commented 1 year ago

Awesome @avisaradir ! Thanks for the contribution!