Change Japanese language code, jp into ja - Githubissues

MihaiValentin / lunr-languages

A collection of languages stemmers and stopwords for Lunr Javascript library

Other

431 stars 163 forks source link

Change Japanese language code, jp into ja #33

Closed fmy closed 7 years ago

fmy commented 7 years ago

I rename jp into ja.

jp is Japan country code, and ja is Japanese language code. https://en.wikipedia.org/wiki/ISO_639-1 // Language code https://en.wikipedia.org/wiki/ISO_3166-2:JP // Country code

For backward-compatibility, I keep lunr.jp.js module. Test codes for both lunr.ja.js and lunr.jp.js modules passed.

Pull request check-list

[X] Describe in detail what you did and why you did it
[X] Add tests. The more the better
- [X] with at least 1 scenario in case of a bug-fix and 4 scenarios in case of a new language
[X] Don't open a Pull request for more unrelated topics. (eg a bug-fix, a new language, and few changes to stemming for existing languages in a single pull request)

MihaiValentin commented 7 years ago

@fmy Thanks for the contribution