Added Arabic language support

MihaiValentin / lunr-languages

A collection of languages stemmers and stopwords for Lunr Javascript library

Other

431 stars 163 forks source link

Added Arabic language support #44

Closed not-dalia closed 4 years ago

not-dalia commented 6 years ago

Added Arabic language support with an experimental stemmer based on the following algorithms:

Kazem Taghva, Rania Elkhoury, and Jeffrey Coombs (2005)
Meryeme Hadni, Abdelmonaime Lachkar, and S. Alaoui Ouatik (2012)

Change build/build.js to include the newly added language. Added test cases for Arabic language.

smit1678 commented 5 years ago

Question from an outsider looking at adding new languages. Is there a reason this PR hasn't been merged for over a year? @MihaiValentin are you accepting new languages if format, docs, and tests all check out correct? Or other criteria being used to evaluate PRs? I haven't tested this or am an Arabic speaker so not commenting on the quality of this one but interested in why no next actions listed here.

MihaiValentin commented 4 years ago

Thanks @not-dalia for adding Arabic to the list of languages!