MihailRis / VoxelEngine-Cpp

Minecraft-like game engine in C++ with OpenGL
585 stars 71 forks source link

#include <settings.hpp> #258

Closed InfiniteCoder01 closed 1 month ago

InfiniteCoder01 commented 3 months ago

Если уже говорить о качестве кода, почему бы не добавить вот эту строчку в CMakeLists.txt

target_include_directories(${PROJECT_NAME} PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src)

И подключать некоторые заголовки используя более приятные пути:

diff --git a/src/world/World.cpp b/src/world/World.cpp
index 3e92ccb..e937ef4 100644
--- a/src/world/World.cpp
+++ b/src/world/World.cpp
@@ -1,18 +1,18 @@
 #include "World.hpp"

 #include "Level.hpp"
-
-#include "../settings.hpp"
-#include "../content/Content.hpp"
-#include "../content/ContentLUT.hpp"
-#include "../debug/Logger.hpp"
-#include "../files/WorldFiles.hpp"
-#include "../items/Inventories.hpp"
-#include "../objects/Player.hpp"
-#include "../voxels/Chunk.hpp"
-#include "../voxels/Chunks.hpp"
-#include "../voxels/ChunksStorage.hpp"
-#include "../world/WorldGenerators.hpp"
+#include "WorldGenerators.hpp"
+
+#include <settings.hpp>
+#include <content/Content.hpp>
+#include <content/ContentLUT.hpp>
+#include <util/debug/Logger.hpp>
+#include <files/WorldFiles.hpp>
+#include <items/Inventories.hpp>
+#include <objects/Player.hpp>
+#include <voxels/Chunk.hpp>
+#include <voxels/Chunks.hpp>
+#include <voxels/ChunksStorage.hpp>

 #include <memory>
 #include <glm/glm.hpp>
MihailRis commented 3 months ago

Если менять, то сразу во всем проекте. В будущем можно будет сделать.