Mihc3 / MP-Reporter

Interested in another addon made by myself? Spending a lot of time in battlegrounds? Check "Battleground Legends", a fun kill reporter!
https://github.com/Mihapro/Battleground-Legends
3 stars 7 forks source link

MPR #1

Closed ahmad565565 closed 9 years ago

ahmad565565 commented 10 years ago

I have some problems. 1st The addon report death sometimes when the player is low hp not when the Player Dies 2nd In some of my alts not reporting anything at all I've tried to reactivate it and still not working 3rd some times Death reporter report the death twice in raid chat Idea. Would be nice if you make Some kind of raid warnings enable/disable Also I'm not experience with writing codes I want to Add some Warnings for Example at marrow " Kill Spike " and at LK When someone is grabbed say in RW "PlayerName Is grabbed" Sorry for my English it's not my Main language

Mihc3 commented 10 years ago

Hopefully fixed in 2ee4b2731396924bbabb114ac1c2c949a4f3f7f8. About your alt characters, not sure what could be wrong. Try toggling /MPR settings and see if you manage to get it working.

See MPR.lua:1048 and MPR.lua:1448. I have added lines that you just have to uncomment (remove "--") to get the warnings you requested working.

ahmad565565 commented 10 years ago

It's working perfectly <3 also as i notice that you only added two raid warnings that i've told you as example, I'll try to cover all the raidwarnings i meant so if you can update it later : ICC Lord Marrow:- spike warning already done Lady:- Mind control ( CC MC People ) When adds appears ( Stop dpsing boss and kill adds ) Rotface:- When ozze explode ( ozze explode gtfo ) Putricide:- Gas bomb (Bottles in the floor Gtfo) Green ooze (Stack) Red Ooze (Red ooze's target Kite ) Council:- When the debuff on Kele (No aoe near Kele) Queen:- Before Terror with 5 secs ( Fear is coming Gtfo from flames ) Sindra:- Track if someone is exploding on raid At 3rd Phase ( stack at right side-marked person go left side ) Lk:- Plague (Plague on NAME) Valks already done Defile in like 5 secs (Defile in 5 sec Spread) Spirits ( Spirits coming, watch out )

RS Halion:- Meteor strike ( Switch to other side ) start of 2nd phase ( Don't enter before tank ) Cutter (Cutter coming in 5 sec) and after cutter(Move back) Toc Twins: When to switch target and when to use Def CDS

I'm sorry for the Long request list, also I know some people doesn't use the same tactics if it's possible to do it private if you don't want to use it for global release

ahmad565565 commented 10 years ago

Death reporter, reporting "player name dead" but he's still alive

Mihc3 commented 10 years ago

Really? Because now it's printing it out only when server sends UNIT_DIED event to client's combat log. Do you know what ability killed the player?

ahmad565565 commented 10 years ago

I'll try to take screenshot and post it here Also it's not usually like that it work perfectly some times and miss sometimes

Mihc3 commented 10 years ago

For custom raid warnings, check functions in MPR_Timers.lua. There you can insert the following line

MPR:RaidWarning("Say something!")

Example

function MPR_Timers:RuneOfBlood()
    --local cd = round(self.DataTimers[4][1],1,true)
    --if cd > 0 then self:NewTimer(GetSpellLink(self:GetSpellID("Rune of Blood")),cd,nil) end
    self.DataTimers[4][1] = 18
    MPR:RaidWarning("Taunt!!")
end

Note that summon wave/adds at Lady Deathwhisper isn't accurate (cooldowns unknown and also different in each difficulty on Molten), so better not putting add announce there.

Mihc3 commented 9 years ago

Fixed. 280cfeae68a6c663b2a9b4fd920e4d69ea64d1bf