search

Mihc3 / MP-Reporter

Interested in another addon made by myself? Spending a lot of time in battlegrounds? Check "Battleground Legends", a fun kill reporter!
https://github.com/Mihapro/Battleground-Legends
3 stars 7 forks source link

MPR crash #3

Open TheFeniks opened 4 years ago

TheFeniks commented 4 years ago

Hey, when a battle starts I get this error message /I've tried with deactivating other addons, nothing seems to work/: Date: 2019-11-07 00:14:23 ID: 7 Error occured in: Global Count: 1 Message: ..\AddOns\MPR\MPR.lua line 1219: attempt to call global 'GetNumGroupMembers' (a nil value) Debug:

MPR\MPR.lua:1219: ?() MPR\MPR.lua:341: MPR\MPR.lua:340 AddOns: ACP, v3.2.0.118 Bagnon, v2.13.3 BagnonForever, v1.1.2 BagnonTooltips Bartender4, v4.4.2-12-g94f3b58 ClassLoot, vr126 CooldownCount, v3.0 Gatherer, v3.1.16 GearScoreLite, v3x04 HealBot, v3.3.5.4.RC2 LootHog, v3.3.3 MPR, vv2.96 Omen, v3.0.9 oRA3, v451 Recount, v1127 Swatter, v5.0.0 DBMCore DBMColiseum

Mihc3 commented 4 years ago

Hi, seems like someone modified it since my last version was 2.9, yours is 2.96 :smile:

GetNumGroupMembers() function was added in Pandaria, for WotLK you should replace it with GetNumRaidMembers(). Find the file (..\AddOns\MPR\MPR.lua), line 1219 and change it.

You might find more bugs, so better download 2.9 version from this repository. :smiley:

TheFeniks commented 4 years ago

I did download it before the 2.96v., but it was the exact same thing even worse - Didnt show the Timers on bosses, nor the dispells, nor the death players. Im currently playing on Wotlk servers. Will give it a shot by changing the line and I will keep you in touch.

TheFeniks commented 4 years ago

Date: 2019-11-08 22:29:30 ID: 28 Error occured in: Global Count: 7 Message: ..\AddOns\MPR\MPR.lua line 1547: attempt to call global 'unit' (a string value) .. .. Date: 2019-11-08 22:30:12 ID: 26 Error occured in: Global Count: 1 Message: ..\AddOns\MPR\MPR.lua line 1533: attempt to call global 'unit' (a string value) .. .. Date: 2019-11-08 22:28:28 ID: 25 Error occured in: Global Count: 1 Message: ..\AddOns\MPR\MPR.lua line 1536: attempt to call global 'unit' (a string value)

These two bug reports happened on PP boss and they occurred in MPR Version 2.70 up until 2.96. What is the cause?

Mihc3 commented 4 years ago

unit should be a function, seems like in your code it's being overwritten by a string. Did you try downloading MPR from this repo? In current MPR.lua there's nothing at lines 1533, 1536 and 1547 calling unit().

Try to give exact info: download source - version - error. People probably took over scripting my addon since boss scripts changed a lot through years, based on your first error they even upgraded it to MoP, so files differ a lot.

TheFeniks commented 4 years ago

Can you add me on discord so that we can chat more freely? Discord: Fenikkussu - DK#5557