Open MihuBot opened 7 months ago
Note: some changes were skipped as they were too large to fit into a comment.
Larger list of diffs: https://gist.github.com/MihuBot/ebd52c631637d4fe672927f0c394ee8e
Larger list of diffs: https://gist.github.com/MihuBot/e1e93d1262c78324549089249ed1d3f8
@MichalPetryka
Build completed in 2 hours 8 minutes. https://github.com/dotnet/runtime/pull/98196
CoreLib diffs
Frameworks diffs
Diffs
``` Found 291 files with textual diffs. Summary of Code Size diffs: (Lower is better) Total bytes of base: 38296082 Total bytes of diff: 38293184 Total bytes of delta: -2898 (-0.01 % of base) Total relative delta: -8.39 diff is an improvement. relative diff is an improvement. Top file regressions (bytes): 42 : Microsoft.Extensions.DependencyInjection.Abstractions.dasm (0.06 % of base) 30 : System.ComponentModel.Composition.dasm (0.01 % of base) 24 : System.Net.Security.dasm (0.01 % of base) 19 : System.ComponentModel.TypeConverter.dasm (0.01 % of base) Top file improvements (bytes): -1323 : System.Data.Common.dasm (-0.08 % of base) -359 : System.Private.CoreLib.dasm (-0.01 % of base) -350 : System.Composition.Convention.dasm (-0.30 % of base) -183 : System.Configuration.ConfigurationManager.dasm (-0.04 % of base) -174 : System.ComponentModel.Composition.Registration.dasm (-0.17 % of base) -151 : System.Private.DataContractSerialization.dasm (-0.02 % of base) -133 : System.Reflection.Emit.dasm (-0.13 % of base) -96 : System.Reflection.MetadataLoadContext.dasm (-0.04 % of base) -74 : System.Net.WebSockets.Client.dasm (-0.32 % of base) -48 : System.Linq.Expressions.dasm (-0.01 % of base) -35 : Microsoft.CSharp.dasm (-0.01 % of base) -18 : System.DirectoryServices.Protocols.dasm (-0.01 % of base) -16 : System.Composition.TypedParts.dasm (-0.03 % of base) -14 : System.Diagnostics.DiagnosticSource.dasm (-0.01 % of base) -10 : System.Reflection.Context.dasm (-0.02 % of base) -7 : System.Text.Json.dasm (-0.00 % of base) -6 : Microsoft.Extensions.Configuration.Binder.dasm (-0.03 % of base) -5 : System.Security.Cryptography.dasm (-0.00 % of base) -4 : tieringtest.dasm (-0.06 % of base) -4 : System.CodeDom.dasm (-0.00 % of base) -3 : System.Private.Xml.dasm (-0.00 % of base) 25 total files with Code Size differences (21 improved, 4 regressed), 231 unchanged. Top method regressions (bytes): 34 (1.74 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.EnumConverter:ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type):System.Object:this (FullOpts) 24 (1.27 % of base) : System.Net.Security.dasm - System.Net.Http.X509ResourceClient:CreateDownloadBytesFunc():System.Func`4[System.String,System.Threading.CancellationToken,ubyte,System.Threading.Tasks.Task`1[ubyte[]]] (FullOpts) 23 (8.42 % of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - Microsoft.Extensions.DependencyInjection.ActivatorUtilities:TryFindPreferredConstructor(System.Type,System.Type[],byref,byref):ubyte (FullOpts) 21 (77.78 % of base) : System.Private.CoreLib.dasm - System.Runtime.Versioning.FrameworkName:op_Equality(System.Runtime.Versioning.FrameworkName,System.Runtime.Versioning.FrameworkName):ubyte (FullOpts) 20 (4.87 % of base) : System.Data.Common.dasm - System.Data.Common.DbProviderFactories:GetFactoryInstance(System.Type):System.Data.Common.DbProviderFactory (FullOpts) 19 (6.86 % of base) : Microsoft.Extensions.DependencyInjection.Abstractions.dasm - Microsoft.Extensions.DependencyInjection.ActivatorUtilities:TryFindMatchingConstructor(System.Type,System.Type[],byref,byref):ubyte (FullOpts) 16 (0.36 % of base) : System.Private.CoreLib.dasm - System.RuntimeType:InvokeMember(System.String,int,System.Reflection.Binder,System.Object,System.Object[],System.Reflection.ParameterModifier[],System.Globalization.CultureInfo,System.String[]):System.Object:this (FullOpts) 15 (29.41 % of base) : System.Private.CoreLib.dasm - System.Runtime.Versioning.FrameworkName:op_Inequality(System.Runtime.Versioning.FrameworkName,System.Runtime.Versioning.FrameworkName):ubyte (FullOpts) 14 (8.70 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Expression:IsLiftingConditionalLogicalOperator(System.Type,System.Type,System.Reflection.MethodInfo,int):ubyte (FullOpts) 13 (1.88 % of base) : Microsoft.CSharp.dasm - Microsoft.CSharp.RuntimeBinder.SymbolTable:AddEventToSymbolTable(System.Reflection.EventInfo,Microsoft.CSharp.RuntimeBinder.Semantics.AggregateSymbol,Microsoft.CSharp.RuntimeBinder.Semantics.FieldSymbol) (FullOpts) 13 (2.50 % of base) : System.Private.CoreLib.dasm - System.Reflection.Metadata.RuntimeTypeMetadataUpdateHandler:ClearCache(System.Type[]) (FullOpts) 12 (8.33 % of base) : System.Private.CoreLib.dasm - System.Attribute:GetParentDefinition(System.Reflection.EventInfo):System.Reflection.EventInfo (FullOpts) 12 (33.33 % of base) : System.Private.CoreLib.dasm - System.Globalization.SortVersion:op_Equality(System.Globalization.SortVersion,System.Globalization.SortVersion):ubyte (FullOpts) 12 (2.76 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Expression:ListInit(System.Linq.Expressions.NewExpression,System.Reflection.MethodInfo,System.Collections.Generic.IEnumerable`1[System.Linq.Expressions.Expression]):System.Linq.Expressions.ListInitExpression (FullOpts) 11 (0.28 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.ReflectionXmlSerializationReader:WritePrimitive(System.Xml.Serialization.TypeMapping,System.Func`2[System.Object,System.String],System.Object):System.Object:this (FullOpts) 10 (1.23 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ReflectTypeDescriptionProvider:ReflectGetProperties(System.Type):System.ComponentModel.PropertyDescriptor[] (FullOpts) 10 (0.97 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Compiler.LambdaCompiler:EmitBranchComparison(ubyte,System.Linq.Expressions.BinaryExpression,System.Reflection.Emit.Label):this (FullOpts) 10 (0.42 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Interpreter.LightCompiler:CompileSwitchExpression(System.Linq.Expressions.Expression):this (FullOpts) 10 (1.61 % of base) : System.Private.CoreLib.dasm - System.Resources.ManifestBasedResourceGroveler:GrovelForResourceSet(System.Globalization.CultureInfo,System.Collections.Generic.Dictionary`2[System.String,System.Resources.ResourceSet],ubyte,ubyte):System.Resources.ResourceSet:this (FullOpts) 10 (0.41 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.ReflectionAwareILGen:ILGenForCreateInstance(System.Xml.Serialization.CodeGenerator,System.Type,System.Type) (FullOpts) 9 (0.49 % of base) : System.Private.CoreLib.dasm - System.RuntimeType+RuntimeTypeCache:GetGenericMethodInfo(long):System.Reflection.MethodInfo:this (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[double]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[int]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[long]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[short]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (6.35 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.__Canon]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.Nullable`1[int]]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[System.Numerics.Vector`1[float]]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (7.92 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.BindingList`1[ubyte]:get_ItemTypeHasDefaultConstructor():ubyte (FullOpts) 8 (4.08 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.ExportServices:IsDictionaryConstructorViewType(System.Type):ubyte (FullOpts) 8 (72.73 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.ReflectionModel.ReflectionProperty:get_CanRead():ubyte:this (FullOpts) 8 (72.73 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.ReflectionModel.ReflectionProperty:get_CanWrite():ubyte:this (FullOpts) 8 (32.00 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.StackFrameExtensions:HasMethod(System.Diagnostics.StackFrame):ubyte (FullOpts) 8 (26.67 % of base) : System.Reflection.Context.dasm - System.Reflection.Context.Virtual.VirtualPropertyBase:get_CanRead():ubyte:this (FullOpts) 8 (26.67 % of base) : System.Reflection.Context.dasm - System.Reflection.Context.Virtual.VirtualPropertyBase:get_CanWrite():ubyte:this (FullOpts) 8 (72.73 % of base) : System.Reflection.Emit.dasm - System.Reflection.Emit.PropertyBuilderImpl:get_CanRead():ubyte:this (FullOpts) 8 (72.73 % of base) : System.Reflection.Emit.dasm - System.Reflection.Emit.PropertyBuilderImpl:get_CanWrite():ubyte:this (FullOpts) 8 (0.38 % of base) : System.Private.CoreLib.dasm - System.Reflection.Emit.SignatureHelper:AddOneArgTypeHelperWorker(System.Type,ubyte):this (FullOpts) 8 (72.73 % of base) : System.Private.CoreLib.dasm - System.Reflection.RuntimePropertyInfo:get_CanRead():ubyte:this (FullOpts) 8 (72.73 % of base) : System.Private.CoreLib.dasm - System.Reflection.RuntimePropertyInfo:get_CanWrite():ubyte:this (FullOpts) 8 (33.33 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoProperty:get_CanRead():ubyte:this (FullOpts) 8 (32.00 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoProperty:get_CanWrite():ubyte:this (FullOpts) 8 (1.30 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.DataContracts.ClassDataContract:IsNonAttributedTypeValidForSerialization(System.Type):ubyte (FullOpts) 8 (1.02 % of base) : System.Runtime.Serialization.Formatters.dasm - System.Runtime.Serialization.ObjectManager:DoValueTypeFixup(System.Reflection.FieldInfo,System.Runtime.Serialization.ObjectHolder,System.Object):ubyte:this (FullOpts) 8 (12.12 % of base) : System.Private.CoreLib.dasm - System.Type:get_IsGenericMethodParameter():ubyte:this (FullOpts) 8 (15.69 % of base) : System.Private.CoreLib.dasm - System.Version:TryParse(System.ReadOnlySpan`1[ushort],byref):ubyte (FullOpts) 8 (9.64 % of base) : System.Private.CoreLib.dasm - System.Version:TryParse(System.String,byref):ubyte (FullOpts) 8 (0.76 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.FieldModel:.ctor(System.Reflection.MemberInfo,System.Type,System.Xml.Serialization.TypeDesc):this (FullOpts) 8 (0.65 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlReflectionImporter:ImportSpecialMapping(System.Type,System.Xml.Serialization.TypeDesc,System.String,int):System.Xml.Serialization.SpecialMapping:this (FullOpts) 8 (0.80 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.IlGen.XmlILVisitor:GetXsltConvertMethod(System.Xml.Xsl.XmlQueryType,System.Xml.Xsl.XmlQueryType,byref):ubyte (FullOpts) 7 (9.72 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.SerializableMapping:.ctor(System.Reflection.MethodInfo,ubyte,System.String):this (FullOpts) 6 (10.00 % of base) : System.Private.CoreLib.dasm - System.Globalization.SortVersion:op_Inequality(System.Globalization.SortVersion,System.Globalization.SortVersion):ubyte (FullOpts) 5 (0.32 % of base) : Microsoft.CSharp.dasm - Microsoft.CSharp.RuntimeBinder.SymbolTable:AddAggregateToSymbolTable(Microsoft.CSharp.RuntimeBinder.Semantics.NamespaceOrAggregateSymbol,System.Type):Microsoft.CSharp.RuntimeBinder.Semantics.AggregateSymbol (FullOpts) 5 (0.40 % of base) : System.ComponentModel.TypeConverter.dasm - System.Drawing.RectangleConverter:ConvertTo(System.ComponentModel.ITypeDescriptorContext,System.Globalization.CultureInfo,System.Object,System.Type):System.Object:this (FullOpts) 5 (0.63 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Compiler.LambdaCompiler:EmitBinaryExpression(System.Linq.Expressions.Expression,int):this (FullOpts) 5 (45.45 % of base) : System.Private.CoreLib.dasm - System.Reflection.Emit.RuntimePropertyBuilder:get_CanRead():ubyte:this (FullOpts) 5 (45.45 % of base) : System.Private.CoreLib.dasm - System.Reflection.Emit.RuntimePropertyBuilder:get_CanWrite():ubyte:this (FullOpts) 4 (1.07 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.BinaryExpression:Create(int,System.Linq.Expressions.Expression,System.Linq.Expressions.Expression,System.Type,System.Reflection.MethodInfo,System.Linq.Expressions.LambdaExpression):System.Linq.Expressions.BinaryExpression (FullOpts) 4 (1.79 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Compiler.LambdaCompiler:GetTestValueType(System.Linq.Expressions.SwitchExpression):System.Type (FullOpts) 4 (1.02 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.MetadataLoadContext:TryFindAssemblyByCallingResolveHandler(System.Reflection.TypeLoading.RoAssemblyName):System.Reflection.TypeLoading.RoAssembly:this (FullOpts) 4 (3.88 % of base) : System.Private.CoreLib.dasm - System.Reflection.RuntimePropertyInfo:GetValue(System.Object,int,System.Reflection.Binder,System.Object[],System.Globalization.CultureInfo):System.Object:this (FullOpts) 4 (1.39 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoAssembly:GetFile(System.String):System.IO.FileStream:this (FullOpts) 4 (1.53 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:EnterContextualReflection(System.Reflection.Assembly):System.Runtime.Loader.AssemblyLoadContext+ContextualReflectionScope (FullOpts) 4 (1.24 % of base) : System.Runtime.Serialization.Formatters.dasm - System.Runtime.Serialization.ValueTypeFixupInfo:.ctor(long,System.Reflection.FieldInfo,int[]):this (FullOpts) 4 (0.45 % of base) : System.Private.CoreLib.dasm - System.StartupHookProvider:CallStartupHook(System.StartupHookProvider+StartupHookNameOrPath) (FullOpts) 4 (0.44 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Runtime.XmlExtensionFunction:Bind():this (FullOpts) 3 (0.20 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ReflectPropertyDescriptor:FillAttributes(System.Collections.IList):this (FullOpts) 3 (0.16 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.BinaryExpression:ReduceIndex():System.Linq.Expressions.Expression:this (FullOpts) 3 (4.17 % of base) : System.Private.CoreLib.dasm - System.Reflection.Metadata.RuntimeTypeMetadataUpdateHandler:SkipAssembly(System.Reflection.Assembly):ubyte (FullOpts) 3 (1.60 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoAssembly:GetRoModule(byref):System.Reflection.TypeLoading.RoModule:this (FullOpts) 3 (0.55 % of base) : System.Reflection.MetadataLoadContext.dasm - System.Reflection.TypeLoading.RoProperty:ComputeIndexParameters():System.Reflection.TypeLoading.RoPropertyIndexParameter[]:this (FullOpts) 3 (0.42 % of base) : System.Private.CoreLib.dasm - System.Resources.ManifestBasedResourceGroveler:GetNeutralResourcesLanguage(System.Reflection.Assembly,byref):System.Globalization.CultureInfo (FullOpts) 3 (0.39 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.TempAssembly:InvokeReader(System.Xml.Serialization.XmlMapping,System.Xml.XmlReader,System.Xml.Serialization.XmlDeserializationEvents,System.String):System.Object:this (FullOpts) 2 (0.31 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.AttributeCollection:GetDefaultAttribute(System.Type):System.Attribute:this (FullOpts) 2 (1.47 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.ReflectionModel.ReflectionExtensions:CreateReflectionProperty(System.Reflection.MethodInfo,System.Reflection.MethodInfo):System.ComponentModel.Composition.ReflectionModel.ReflectionProperty (FullOpts) 2 (1.87 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.ReflectionModel.ReflectionProperty:.ctor(System.Reflection.MethodInfo,System.Reflection.MethodInfo):this (FullOpts) 2 (1.44 % of base) : System.ComponentModel.Composition.dasm - System.ComponentModel.Composition.ReflectionModel.ReflectionProperty:get_ReturnType():System.Type:this (FullOpts) 2 (0.40 % of base) : System.ComponentModel.Composition.Registration.dasm - System.ComponentModel.Composition.Registration.PartBuilder:BuildConstructorAttributes(System.Type,byref):ubyte:this (FullOpts) 2 (0.69 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.MemberDescriptor:FindMethod(System.Type,System.String,System.Type[],System.Type):System.Reflection.MethodInfo (FullOpts) 2 (0.18 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ReflectEventDescriptor:FillMethods():this (FullOpts) 2 (0.22 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ReflectPropertyDescriptor:get_GetMethodValue():System.Reflection.MethodInfo:this (FullOpts) 2 (0.45 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ReflectPropertyDescriptor:get_ResetMethodValue():System.Reflection.MethodInfo:this (FullOpts) 2 (0.45 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.ReflectPropertyDescriptor:get_ShouldSerializeMethodValue():System.Reflection.MethodInfo:this (FullOpts) 2 (0.40 % of base) : System.Composition.Convention.dasm - System.Composition.Convention.PartConventionBuilder:BuildConstructorAttributes(System.Type,byref):ubyte:this (FullOpts) 2 (0.15 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Compiler.LambdaCompiler:EmitUnary(System.Linq.Expressions.UnaryExpression,int):this (FullOpts) 2 (0.24 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Expression:GetUserDefinedBinaryOperator(int,System.String,System.Linq.Expressions.Expression,System.Linq.Expressions.Expression,ubyte):System.Linq.Expressions.BinaryExpression (FullOpts) 2 (0.37 % of base) : System.Linq.Expressions.dasm - System.Linq.Expressions.Expression:GetUserDefinedUnaryOperator(int,System.String,System.Linq.Expressions.Expression):System.Linq.Expressions.UnaryExpression (FullOpts) 2 (0.87 % of base) : System.Reflection.Context.dasm - System.Reflection.Context.CustomReflectionContext+ReflectionContextProjector:ProjectMethodBase(System.Reflection.MethodBase):System.Reflection.MethodBase:this (FullOpts) 2 (1.35 % of base) : System.Private.CoreLib.dasm - System.Reflection.RuntimeParameterInfo:GetRuntimeModule():System.Reflection.RuntimeModule:this (FullOpts) 2 (0.25 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.ReflectionXmlSerializationReaderHelper:GetSetMemberValueDelegateWithType[System.__Canon,System.Nullable`1[int]](System.Reflection.MemberInfo):System.Xml.Serialization.ReflectionXmlSerializationReaderHelper+SetMemberValueDelegate (FullOpts) 2 (1.21 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.IlGen.XmlILModule:DefineMethodBody(System.Reflection.MethodBase):System.Reflection.Emit.ILGenerator (FullOpts) 1 (0.15 % of base) : System.Private.CoreLib.dasm - System.Reflection.CustomAttribute:GetCustomAttributes(System.Reflection.RuntimeMethodInfo,System.RuntimeType,ubyte):System.Object[] (FullOpts) Top method improvements (bytes): -84 (-9.89 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ConfigurationSection:SerializeSection(System.Configuration.ConfigurationElement,System.String,int):System.String:this (FullOpts) -67 (-12.88 % of base) : System.Reflection.Emit.dasm - System.Reflection.Emit.ILGeneratorImpl:Emit(System.Reflection.Emit.OpCode,System.Reflection.Emit.LocalBuilder):this (FullOpts) -42 (-0.75 % of base) : System.Net.WebSockets.Client.dasm - System.Net.WebSockets.WebSocketHandle+Artifacts: