Open MihuBot opened 2 weeks ago
Note: some changes were skipped as they were too large to fit into a comment.
Larger list of diffs: https://gist.github.com/MihuBot/c54888accd0bed90e3c5cc3d6fef73c8
Note: some changes were skipped as they were too large to fit into a comment.
Larger list of diffs: https://gist.github.com/MihuBot/c35e5bc125dac4b410662da81d33240c
@EgorBo
Job completed in 16 minutes. https://github.com/dotnet/runtime/pull/103813
Diffs
Diffs
``` Found 319 files with textual diffs. Summary of Code Size diffs: (Lower is better) Total bytes of base: 41604177 Total bytes of diff: 41667764 Total bytes of delta: 63587 (0.15 % of base) Total relative delta: 3136.76 diff is a regression. relative diff is a regression. Top file regressions (bytes): 12118 : System.Data.Common.dasm (0.72 % of base) 11736 : System.Private.CoreLib.dasm (0.16 % of base) 5961 : System.Net.Sockets.dasm (2.28 % of base) 3414 : System.Data.Odbc.dasm (1.43 % of base) 2936 : System.Net.Security.dasm (1.26 % of base) 2763 : System.Net.Http.dasm (0.34 % of base) 2637 : System.Security.Cryptography.dasm (0.24 % of base) 1781 : System.IO.Ports.dasm (3.50 % of base) 1771 : System.Diagnostics.Process.dasm (1.80 % of base) 1750 : System.Net.WebClient.dasm (3.10 % of base) 1537 : System.Threading.Tasks.Dataflow.dasm (0.11 % of base) 966 : System.DirectoryServices.dasm (1.27 % of base) 929 : System.IO.Pipes.dasm (2.38 % of base) 907 : System.CodeDom.dasm (0.43 % of base) 886 : System.Management.dasm (2.48 % of base) 868 : System.ComponentModel.TypeConverter.dasm (0.27 % of base) 731 : System.Net.Ping.dasm (1.39 % of base) 717 : System.DirectoryServices.Protocols.dasm (0.49 % of base) 653 : System.Transactions.Local.dasm (0.43 % of base) 648 : System.IO.FileSystem.Watcher.dasm (2.31 % of base) 593 : Microsoft.VisualBasic.Core.dasm (0.11 % of base) 558 : System.IO.Compression.dasm (0.58 % of base) 544 : System.Data.OleDb.dasm (2.29 % of base) 517 : System.IO.IsolatedStorage.dasm (2.27 % of base) 388 : System.Diagnostics.DiagnosticSource.dasm (0.15 % of base) 355 : Microsoft.Extensions.Caching.Memory.dasm (1.65 % of base) 350 : System.ComponentModel.EventBasedAsync.dasm (8.12 % of base) 334 : System.Net.Requests.dasm (0.23 % of base) 325 : System.Configuration.ConfigurationManager.dasm (0.08 % of base) 264 : System.Net.Mail.dasm (0.14 % of base) 258 : System.ServiceProcess.ServiceController.dasm (3.85 % of base) 232 : System.Diagnostics.PerformanceCounter.dasm (2.02 % of base) 222 : System.Speech.dasm (0.40 % of base) 220 : System.ComponentModel.Primitives.dasm (1.30 % of base) 217 : System.Diagnostics.EventLog.dasm (0.97 % of base) 208 : System.Net.Quic.dasm (0.14 % of base) 205 : System.Private.Xml.dasm (0.00 % of base) 198 : System.Threading.dasm (1.14 % of base) 190 : System.Reflection.Metadata.dasm (0.03 % of base) 182 : Microsoft.Extensions.DependencyInjection.dasm (0.23 % of base) 178 : System.Net.WebSockets.dasm (0.15 % of base) 155 : System.Net.NameResolution.dasm (0.39 % of base) 132 : Microsoft.Extensions.Logging.EventSource.dasm (0.57 % of base) 121 : Microsoft.Extensions.Hosting.WindowsServices.dasm (1.53 % of base) 116 : System.Windows.Extensions.dasm (2.80 % of base) 112 : System.Runtime.InteropServices.dasm (0.44 % of base) 104 : System.Linq.Parallel.dasm (0.00 % of base) 98 : System.Runtime.Caching.dasm (0.16 % of base) 72 : System.IO.MemoryMappedFiles.dasm (0.34 % of base) 59 : runincontext.dasm (0.38 % of base) 58 : System.IO.Compression.Brotli.dasm (0.26 % of base) 42 : System.Net.Primitives.dasm (0.05 % of base) 38 : System.Security.Principal.Windows.dasm (0.44 % of base) 36 : System.Net.HttpListener.dasm (0.03 % of base) 34 : Microsoft.Win32.Registry.dasm (0.54 % of base) 34 : System.Resources.Extensions.dasm (0.06 % of base) 30 : System.Collections.Concurrent.dasm (0.01 % of base) 28 : System.Threading.Tasks.Parallel.dasm (0.01 % of base) 26 : ILCompiler.Reflection.ReadyToRun.dasm (0.01 % of base) 25 : System.Net.NetworkInformation.dasm (0.05 % of base) 20 : System.Text.Encoding.CodePages.dasm (0.03 % of base) 61 total files with Code Size differences (0 improved, 61 regressed), 197 unchanged. Top method regressions (bytes): 210 (4.42 % of base) : System.Data.Common.dasm - System.Data.DataTable:ReadXml(System.Xml.XmlReader,int,ubyte):int:this (FullOpts) 205 (4.94 % of base) : System.Data.Common.dasm - System.Data.DataTable:ReadXml(System.Xml.XmlReader,ubyte):int:this (FullOpts) 94 (7.54 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:WriteEventString(System.String):this (FullOpts) 90 (5.14 % of base) : System.IO.FileSystem.Watcher.dasm - System.IO.FileSystemWatcher:WaitForChanged(int,int):System.IO.WaitForChangedResult:this (FullOpts) 87 (9.02 % of base) : System.Private.CoreLib.dasm - System.Runtime.Loader.AssemblyLoadContext:ResolveSatelliteAssembly(System.Reflection.AssemblyName):System.Reflection.Assembly:this (FullOpts) 84 (4.25 % of base) : System.Data.Common.dasm - System.Data.DataView:ToTable(System.String,ubyte,System.String[]):System.Data.DataTable:this (FullOpts) 77 (4.57 % of base) : System.Net.Http.dasm - System.Net.Http.Http2Connection:Abort(System.Exception):this (FullOpts) 70 (2.18 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXmlDiffgram(System.Xml.XmlReader):this (FullOpts) 68 (4.10 % of base) : System.Private.CoreLib.dasm - Microsoft.Win32.SafeHandles.SafeFileHandle:Init(System.String,int,int,int,int,long,byref,byref):ubyte:this (FullOpts) 68 (2.54 % of base) : System.Data.Common.dasm - System.Data.DataTable:CloneTo(System.Data.DataTable,System.Data.DataSet,ubyte):System.Data.DataTable:this (FullOpts) 68 (5.84 % of base) : System.Data.Common.dasm - System.Data.DataTable:set_TableName(System.String):this (FullOpts) 65 (2.92 % of base) : System.Net.Security.dasm - System.Net.Security.SslStream:VerifyRemoteCertificate(System.Net.Security.RemoteCertificateValidationCallback,System.Net.Security.SslCertificateTrust,byref,byref,byref):ubyte:this (FullOpts) 53 (2.67 % of base) : System.Data.Common.dasm - System.Data.DataTable:MergeRow(System.Data.DataRow,System.Data.DataRow,ubyte,System.Data.Index):System.Data.DataRow:this (FullOpts) 52 (1.01 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:SendRequestHelper(System.DirectoryServices.Protocols.DirectoryRequest,byref):int:this (FullOpts) 51 (6.29 % of base) : System.Data.Common.dasm - System.Data.DataColumn:Clone():System.Data.DataColumn:this (FullOpts) 50 (3.57 % of base) : System.Net.Http.dasm - System.Net.Http.Http2Connection:WriteHeaderCollection(System.Net.Http.HttpRequestMessage,System.Net.Http.Headers.HttpHeaders,byref):int:this (FullOpts) 47 (1.83 % of base) : System.Data.Common.dasm - System.Data.DataSet:Clone():System.Data.DataSet:this (FullOpts) 47 (1.02 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXml(System.Xml.XmlReader,int,ubyte):int:this (FullOpts) 47 (1.25 % of base) : System.Data.Odbc.dasm - System.Data.Odbc.OdbcCommand:ExecuteReaderObject(int,System.String,ubyte,System.Object[],ushort):System.Data.Odbc.OdbcDataReader:this (FullOpts) 46 (6.01 % of base) : System.Data.Common.dasm - System.Data.DataTable:set_Namespace(System.String):this (FullOpts) 45 (8.17 % of base) : System.Net.WebClient.dasm - System.Net.WebClient:PostProgressChanged(System.ComponentModel.AsyncOperation,System.Net.WebClient+ProgressData):this (FullOpts) 43 (3.54 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:ConstructParsedResult(long,byref,byref,byref,byref,byref):int:this (FullOpts) 42 (6.03 % of base) : System.Net.Http.dasm - System.Net.Http.Http2Connection:ProcessGoAwayFrame(System.Net.Http.Http2Connection+FrameHeader):this (FullOpts) 41 (8.60 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.Container:Add(System.ComponentModel.IComponent,System.String):this (FullOpts) 41 (4.16 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialStream:ProcessRead(System.IO.Ports.SerialStream+SerialStreamIORequest):int:this (FullOpts) 40 (5.30 % of base) : System.Data.Common.dasm - System.Data.DataTable:LoadDataRow(System.Object[],int):System.Data.DataRow:this (FullOpts) 40 (50.00 % of base) : System.Data.Odbc.dasm - System.Data.Odbc.OdbcConnection:FlagUnsupportedStmtAttr(int):this (FullOpts) 39 (4.03 % of base) : System.Data.Common.dasm - System.Data.DataColumn:set_ColumnName(System.String):this (FullOpts) 39 (3.75 % of base) : System.Data.Common.dasm - System.Data.DataTable:GetRowAndColumnErrors(int,System.Collections.Hashtable,System.Collections.Hashtable):this (FullOpts) 37 (0.78 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXml(System.Xml.XmlReader,ubyte):int:this (FullOpts) 37 (5.37 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.FromBase64Transform:TransformFinalBlock(ubyte[],int,int):ubyte[]:this (FullOpts) 36 (4.63 % of base) : System.Data.Common.dasm - System.Data.DataSet:ValidateLocaleConstraint():ubyte:this (FullOpts) 36 (12.20 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:UpdateDescriptor(System.String,System.Diagnostics.Tracing.TraceLoggingEventTypes,byref,byref):System.Diagnostics.Tracing.NameInfo:this (FullOpts) 35 (7.53 % of base) : System.ComponentModel.TypeConverter.dasm - System.ComponentModel.Container:get_Components():System.ComponentModel.ComponentCollection:this (FullOpts) 34 (8.42 % of base) : System.Net.Security.dasm - Microsoft.Win32.SafeHandles.SafeSslContextHandle:RemoveSession(long,long):this (FullOpts) 33 (1.59 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXmlSchema(System.Xml.XmlReader,ubyte):this (FullOpts) 33 (12.45 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.NativeRuntimeEventSource:ThreadPoolMinMaxThreads(ushort,ushort,ushort,ushort,ushort):this (FullOpts) 32 (1.50 % of base) : System.Data.Common.dasm - System.Data.DataTable:EvaluateDependentExpressions(System.Collections.Generic.List`1[System.Data.DataColumn],System.Data.DataRow,int,System.Collections.Generic.List`1[System.Data.DataRow]):this (FullOpts) 32 (3.71 % of base) : System.Data.Common.dasm - System.Data.DataTable:ImportRow(System.Data.DataRow):this (FullOpts) 32 (58.18 % of base) : System.Data.Odbc.dasm - System.Data.Odbc.OdbcConnection:FlagUnsupportedConnectAttr(int):this (FullOpts) 32 (3.70 % of base) : System.IO.Ports.dasm - System.IO.Ports.SerialStream:IOLoop():this (FullOpts) 32 (3.68 % of base) : System.Net.Http.dasm - System.Net.Http.Http2Connection:ChangeInitialWindowSize(int):this (FullOpts) 30 (45.45 % of base) : System.Data.Common.dasm - System.Data.DataColumn:ToString():System.String:this (FullOpts) 30 (2.79 % of base) : System.Data.Common.dasm - System.Data.DataSet:Copy():System.Data.DataSet:this (FullOpts) 30 (8.50 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.NativeRuntimeEventSource:ThreadPoolWorkerThreadAdjustmentStats(double,double,double,double,double,double,double,double,double,ushort,ushort):this (FullOpts) 30 (6.30 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.SafeSocketHandle:TryUnblockSocket(ubyte):ubyte:this (FullOpts) 29 (3.62 % of base) : System.Data.Common.dasm - System.Data.DataSet:set_Namespace(System.String):this (FullOpts) 29 (4.21 % of base) : System.Data.Common.dasm - System.Data.DataTable:ConvertToRowError(int,System.Collections.Hashtable,System.Collections.Hashtable):this (FullOpts) 29 (7.09 % of base) : System.Data.Common.dasm - System.Data.DataTable:GetInheritedNamespace(System.Collections.Generic.List`1[System.Data.DataTable]):System.String:this (FullOpts) 29 (1.21 % of base) : System.Data.Common.dasm - System.Data.DataTable:ReadXmlDiffgram(System.Xml.XmlReader):this (FullOpts) 29 (6.71 % of base) : System.Diagnostics.Process.dasm - System.Diagnostics.Process:Kill():this (FullOpts) 29 (3.44 % of base) : System.DirectoryServices.Protocols.dasm - System.DirectoryServices.Protocols.LdapConnection:ConstructReference(long):System.DirectoryServices.Protocols.SearchResultReference:this (FullOpts) 29 (7.46 % of base) : System.Net.Http.dasm - System.Net.Http.Http2Connection:WaitForAvailableStreamsAsync():System.Threading.Tasks.Task`1[ubyte]:this (FullOpts) 29 (74.36 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.Socket:CanTryAddressFamily(int):ubyte:this (FullOpts) 29 (2.27 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.Socket:SendTo(ubyte[],int,int,int,System.Net.EndPoint):int:this (FullOpts) 28 (1.15 % of base) : System.Data.Common.dasm - System.Data.Common.DbCommandBuilder:BuildWhereClause(System.Data.Common.DataTableMapping,System.Data.DataRow,System.Text.StringBuilder,System.Data.Common.DbCommand,int,ubyte):int:this (FullOpts) 28 (0.62 % of base) : System.Data.Common.dasm - System.Data.Common.DbDataAdapter:Update(System.Data.DataRow[],System.Data.Common.DataTableMapping):int:this (FullOpts) 28 (3.37 % of base) : System.Data.Common.dasm - System.Data.DataView:AddNew():System.Data.DataRowView:this (FullOpts) 28 (2.41 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:ThrowEventSourceException(System.String,System.Exception):this (FullOpts) 28 (2.28 % of base) : System.Net.Http.dasm - System.Net.Http.Http2Connection:ChangeMaxConcurrentStreams(uint):this (FullOpts) 28 (4.90 % of base) : System.Net.Sockets.dasm - System.Net.Sockets.Socket+AwaitableSocketAsyncEventArgs:ReceiveMessageFromAsync(System.Net.Sockets.Socket,System.Threading.CancellationToken):System.Threading.Tasks.ValueTask`1[System.Net.Sockets.SocketReceiveMessageFromResult]:this (FullOpts) 28 (6.91 % of base) : System.Private.CoreLib.dasm - System.Runtime.InteropServices.PosixSignalRegistration:Unregister():this (FullOpts) 28 (11.43 % of base) : System.Threading.Tasks.Dataflow.dasm - System.Threading.Tasks.Dataflow.DataflowBlock+SendAsyncSource`1[double]:System.Threading.Tasks.Dataflow.ISourceBlockArtifacts: