Open MihuBot opened 7 hours ago
Note: some changes were skipped as they were too large to fit into a comment.
Larger list of diffs: https://gist.github.com/MihuBot/c38eda4ccf75afd288c83f086399f129
Note: some changes were skipped as they were too large to fit into a comment.
Larger list of diffs: https://gist.github.com/MihuBot/0860e11beb422aa0557d87ca80b0523b
@EgorBo
Job completed in 16 minutes 42 seconds. https://github.com/dotnet/runtime/pull/109036
Diffs
Diffs
``` Found 384 files with textual diffs. Summary of Code Size diffs: (Lower is better) Total bytes of base: 48145688 Total bytes of diff: 48166780 Total bytes of delta: 21092 (0.04 % of base) Total relative delta: 63.17 diff is a regression. relative diff is a regression. Total byte diff includes -476 bytes from reconciling methods Base had 1 unique methods, 476 unique bytes Diff had 0 unique methods, 0 unique bytes Top file regressions (bytes): 4796 : System.Data.Common.dasm (0.24 % of base) 4660 : System.Private.DataContractSerialization.dasm (0.37 % of base) 4248 : System.Linq.Parallel.dasm (0.17 % of base) 2500 : System.ComponentModel.Annotations.dasm (3.67 % of base) 2464 : System.Private.Xml.dasm (0.05 % of base) 1172 : System.Text.Json.dasm (0.07 % of base) 1020 : System.Data.Odbc.dasm (0.35 % of base) 760 : System.ServiceModel.Syndication.dasm (0.39 % of base) 748 : System.Security.Cryptography.Xml.dasm (0.31 % of base) 472 : System.Configuration.ConfigurationManager.dasm (0.09 % of base) 316 : System.Security.Cryptography.dasm (0.02 % of base) 300 : System.Net.ServerSentEvents.dasm (0.70 % of base) 216 : System.Security.Cryptography.Pkcs.dasm (0.05 % of base) 176 : System.Reflection.Emit.dasm (0.12 % of base) 172 : System.Private.Xml.Linq.dasm (0.08 % of base) 132 : System.Collections.Concurrent.dasm (0.03 % of base) 108 : System.Composition.Hosting.dasm (0.08 % of base) 104 : Microsoft.Extensions.Diagnostics.dasm (0.56 % of base) 104 : System.Net.WebClient.dasm (0.16 % of base) 96 : System.Private.CoreLib.dasm (0.00 % of base) 92 : Microsoft.VisualBasic.Core.dasm (0.01 % of base) 76 : System.ComponentModel.Composition.Registration.dasm (0.06 % of base) 72 : System.CodeDom.dasm (0.03 % of base) 60 : System.Net.HttpListener.dasm (0.05 % of base) 56 : System.Threading.Tasks.Dataflow.dasm (0.00 % of base) 56 : Microsoft.Extensions.Logging.Configuration.dasm (0.59 % of base) 52 : System.Text.Encoding.CodePages.dasm (0.06 % of base) 48 : System.Reflection.MetadataLoadContext.dasm (0.02 % of base) 48 : System.Net.NetworkInformation.dasm (0.07 % of base) 44 : System.IO.Packaging.dasm (0.03 % of base) 40 : System.Threading.RateLimiting.dasm (0.02 % of base) 28 : System.Net.NameResolution.dasm (0.05 % of base) 28 : ILCompiler.Reflection.ReadyToRun.dasm (0.01 % of base) 24 : Microsoft.Extensions.Logging.dasm (0.05 % of base) 24 : Microsoft.Extensions.Hosting.dasm (0.03 % of base) 24 : System.IO.Compression.dasm (0.02 % of base) 24 : System.Security.Permissions.dasm (0.07 % of base) 20 : System.Net.Requests.dasm (0.01 % of base) 20 : System.ComponentModel.TypeConverter.dasm (0.01 % of base) 16 : Microsoft.CSharp.dasm (0.00 % of base) 16 : System.Threading.Channels.dasm (0.01 % of base) 16 : Microsoft.Extensions.DependencyInjection.Abstractions.dasm (0.02 % of base) 16 : System.Net.Http.Json.dasm (0.01 % of base) 12 : System.ObjectModel.dasm (0.01 % of base) 12 : System.Text.RegularExpressions.dasm (0.00 % of base) 12 : Microsoft.Extensions.Caching.Abstractions.dasm (0.03 % of base) 12 : System.Text.Encodings.Web.dasm (0.04 % of base) 8 : Microsoft.Win32.SystemEvents.dasm (0.14 % of base) 8 : System.Net.WebProxy.dasm (0.11 % of base) 8 : System.Threading.dasm (0.04 % of base) 8 : System.IO.Compression.ZipFile.dasm (0.04 % of base) 8 : System.Collections.dasm (0.00 % of base) 8 : Microsoft.Extensions.Caching.Memory.dasm (0.04 % of base) 8 : System.Net.WebSockets.dasm (0.00 % of base) 8 : System.Reflection.Context.dasm (0.01 % of base) 4 : System.Diagnostics.TraceSource.dasm (0.01 % of base) 4 : System.Net.WebHeaderCollection.dasm (0.02 % of base) 4 : System.Formats.Tar.dasm (0.00 % of base) 4 : System.Runtime.Numerics.dasm (0.00 % of base) 4 : System.Net.WebSockets.Client.dasm (0.01 % of base) Top file improvements (bytes): -2084 : System.Formats.Asn1.dasm (-1.93 % of base) -776 : System.Reflection.Metadata.dasm (-0.11 % of base) -208 : System.ComponentModel.Primitives.dasm (-0.90 % of base) -196 : System.Diagnostics.DiagnosticSource.dasm (-0.06 % of base) -100 : System.Linq.dasm (-0.01 % of base) -96 : System.Composition.TypedParts.dasm (-0.16 % of base) -88 : System.Composition.Convention.dasm (-0.06 % of base) -84 : System.ComponentModel.Composition.dasm (-0.02 % of base) -72 : System.Transactions.Local.dasm (-0.04 % of base) -68 : System.Net.Security.dasm (-0.02 % of base) -60 : System.Resources.Writer.dasm (-0.54 % of base) -48 : System.DirectoryServices.Protocols.dasm (-0.03 % of base) -48 : System.Resources.Extensions.dasm (-0.08 % of base) -40 : System.Reflection.DispatchProxy.dasm (-0.17 % of base) -40 : System.Runtime.Serialization.Schema.dasm (-0.06 % of base) -40 : System.Net.Http.dasm (-0.00 % of base) -40 : System.Net.Quic.dasm (-0.02 % of base) -36 : Microsoft.Extensions.FileSystemGlobbing.dasm (-0.11 % of base) -32 : System.Console.dasm (-0.03 % of base) -32 : System.Runtime.Caching.dasm (-0.04 % of base) -32 : Microsoft.Extensions.Logging.Console.dasm (-0.04 % of base) -28 : System.Collections.Immutable.dasm (-0.00 % of base) -28 : System.IO.FileSystem.DriveInfo.dasm (-0.09 % of base) -28 : System.Linq.Expressions.dasm (-0.00 % of base) -24 : System.Threading.Tasks.Parallel.dasm (-0.01 % of base) -24 : System.Net.Primitives.dasm (-0.02 % of base) -24 : Microsoft.Extensions.Http.dasm (-0.03 % of base) -20 : Microsoft.Extensions.Configuration.dasm (-0.09 % of base) -20 : Microsoft.Extensions.DependencyInjection.dasm (-0.02 % of base) -16 : System.IO.FileSystem.Watcher.dasm (-0.05 % of base) -12 : Microsoft.Extensions.Configuration.Xml.dasm (-0.09 % of base) -8 : System.Net.Sockets.dasm (-0.00 % of base) -8 : System.Runtime.InteropServices.dasm (-0.03 % of base) -8 : Microsoft.Extensions.DependencyModel.dasm (-0.01 % of base) -4 : System.Net.Ping.dasm (-0.01 % of base) -4 : System.Diagnostics.StackTrace.dasm (-0.11 % of base) -4 : Microsoft.Extensions.Logging.EventSource.dasm (-0.01 % of base) -4 : Microsoft.Extensions.Configuration.Json.dasm (-0.05 % of base) -4 : System.Memory.dasm (-0.00 % of base) -4 : Microsoft.Extensions.Configuration.Ini.dasm (-0.08 % of base) -4 : System.Security.Claims.dasm (-0.02 % of base) -4 : Microsoft.Extensions.Options.dasm (-0.01 % of base) -4 : System.Formats.Nrbf.dasm (-0.01 % of base) 103 total files with Code Size differences (43 improved, 60 regressed), 156 unchanged. Top method regressions (bytes): 840 (48.17 % of base) : System.Data.Common.dasm - System.Data.XDRSchema:FindTypeNode(System.Xml.XmlElement):System.Xml.XmlElement (FullOpts) 484 (46.01 % of base) : System.Text.Json.dasm - System.Text.Json.Reflection.ReflectionExtensions:IsImmutableEnumerableType(System.Type):ubyte (FullOpts) 464 (45.49 % of base) : System.Text.Json.dasm - System.Text.Json.Reflection.ReflectionExtensions:GetImmutableEnumerableConstructingTypeName(System.Type):System.String (FullOpts) 460 (9.14 % of base) : System.Security.Cryptography.Xml.dasm - System.Security.Cryptography.Xml.CryptoHelpers:CreateFromKnownName(System.String):System.Object (FullOpts) 328 (6.44 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXml(System.Xml.XmlReader,ubyte):int:this (FullOpts) 328 (6.93 % of base) : System.Data.Common.dasm - System.Data.DataTable:ReadXml(System.Xml.XmlReader,ubyte):int:this (FullOpts) 260 (4.87 % of base) : System.Data.Common.dasm - System.Data.DataTable:ReadXml(System.Xml.XmlReader,int,ubyte):int:this (FullOpts) 248 (19.31 % of base) : System.ComponentModel.Annotations.dasm - System.ComponentModel.DataAnnotations.CustomValidationAttribute:ValidateMethodParameter():System.String:this (FullOpts) 248 (4.99 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXml(System.Xml.XmlReader,int,ubyte):int:this (FullOpts) 240 (8.89 % of base) : System.Data.Common.dasm - System.Data.DataTable:ReadXmlDiffgram(System.Xml.XmlReader):this (FullOpts) 184 (4.78 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXmlDiffgram(System.Xml.XmlReader):this (FullOpts) 172 (6.61 % of base) : System.Data.Common.dasm - System.Data.DataSet:ReadXmlSchema(System.Xml.XmlReader,ubyte):this (FullOpts) 160 (6.20 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.XmlBaseWriter:StartAttribute(byref,System.String,System.String,System.Xml.XmlDictionaryString):this (FullOpts) 152 (122.58 % of base) : System.Configuration.ConfigurationManager.dasm - System.Configuration.ClientConfigurationHost:IsUserConfig(System.String):ubyte (FullOpts) 152 (14.79 % of base) : System.Reflection.Emit.dasm - System.Reflection.Emit.ParameterBuilderImpl:SetCustomAttributeCore(System.Reflection.ConstructorInfo,System.ReadOnlySpan`1[ubyte]):this (FullOpts) 132 (23.57 % of base) : System.ComponentModel.Annotations.dasm - System.ComponentModel.DataAnnotations.RangeAttribute:GetValidationErrorMessage():System.String:this (FullOpts) 132 (11.00 % of base) : System.Private.Xml.Linq.dasm - System.Xml.Linq.XAttribute:ValidateAttribute(System.Xml.Linq.XName,System.String) (FullOpts) 128 (4.46 % of base) : System.Data.Common.dasm - System.Data.XDRSchema:HandleColumn(System.Xml.XmlElement,System.Data.DataTable):this (FullOpts) 124 (4.51 % of base) : System.Data.Common.dasm - System.Data.XSDSchema:HandleSimpleTypeSimpleContentColumn(System.Xml.Schema.XmlSchemaSimpleType,System.String,System.Data.DataTable,ubyte,System.Xml.XmlAttribute[],ubyte):this (FullOpts) 120 (30.00 % of base) : System.ComponentModel.Annotations.dasm - System.ComponentModel.DataAnnotations.CustomValidationAttribute:ValidateValidatorTypeParameter():System.String:this (FullOpts) 116 (14.87 % of base) : System.Private.CoreLib.dasm - System.Runtime.CompilerServices.RuntimeFeature:IsSupported(System.String):ubyte (FullOpts) 112 (6.62 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.XmlBaseWriter+NamespaceManager:AddNamespace(System.String,System.String,System.Xml.XmlDictionaryString):this (FullOpts) 108 (14.29 % of base) : System.Data.Common.dasm - System.Data.XDRSchema:HandleTypeNode(System.Xml.XmlElement,System.Data.DataTable,System.Collections.ArrayList):this (FullOpts) 108 (5.05 % of base) : System.Data.Common.dasm - System.Data.XSDSchema:HandleSimpleContentColumn(System.String,System.Data.DataTable,ubyte,System.Xml.XmlAttribute[],ubyte):this (FullOpts) 108 (27.55 % of base) : System.Private.CoreLib.dasm - System.Diagnostics.Tracing.EventSource:AttributeTypeNamesMatch(System.Type,System.Type):ubyte (FullOpts) 104 (13.40 % of base) : Microsoft.Extensions.Diagnostics.dasm - Microsoft.Extensions.Diagnostics.Metrics.Configuration.MetricsConfigureOptions:LoadConfig(Microsoft.Extensions.Diagnostics.Metrics.MetricsOptions):this (FullOpts) 104 (17.81 % of base) : System.Data.Common.dasm - System.Data.XMLDiffLoader:LoadDiffGram(System.Data.DataSet,System.Xml.XmlReader):this (FullOpts) 100 (18.12 % of base) : System.Data.Odbc.dasm - System.Data.Odbc.TypeMap:FromSqlType(short):System.Data.Odbc.TypeMap (FullOpts) 100 (9.80 % of base) : System.Net.WebClient.dasm - System.Net.WebClient:GetValuesToUpload(System.Collections.Specialized.NameValueCollection):ubyte[]:this (FullOpts) 96 (20.87 % of base) : System.Data.Odbc.dasm - System.Data.Odbc.TypeMap:FromOdbcType(int):System.Data.Odbc.TypeMap (FullOpts) 96 (12.90 % of base) : System.Data.Common.dasm - System.Data.XMLDiffLoader:LoadDiffGram(System.Data.DataTable,System.Xml.XmlReader):this (FullOpts) 96 (4.90 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.AtomPub10ServiceDocumentFormatter:ReadReferencedCategories(System.Xml.XmlReader,System.ServiceModel.Syndication.ReferencedCategoriesDocument,System.Uri,System.Uri,System.String,int) (FullOpts) 92 (12.23 % of base) : System.Data.Common.dasm - System.Data.XDRSchema:IsXDRField(System.Xml.XmlElement,System.Xml.XmlElement):ubyte (FullOpts) 92 (8.81 % of base) : System.Data.Common.dasm - System.Data.XmlDataLoader:LoadRows(System.Data.DataRow,System.Xml.XmlNode):this (FullOpts) 92 (5.76 % of base) : System.Private.Xml.dasm - System.Xml.XmlWellFormedWriter:PushNamespaceExplicit(System.String,System.String):ubyte:this (FullOpts) 92 (4.77 % of base) : System.Private.Xml.dasm - System.Xml.XmlWellFormedWriter:WriteStartAttribute(System.String,System.String,System.String):this (FullOpts) 88 (3.42 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.AtomPub10ServiceDocumentFormatter:ReadInlineCategories(System.Xml.XmlReader,System.ServiceModel.Syndication.InlineCategoriesDocument,System.Uri,System.String,int) (FullOpts) 88 (13.84 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.TempAssembly:ValidateEncodingStyle(System.String,System.String):System.String:this (FullOpts) 88 (1.10 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSerializationReaderILGen:WritePrimitive(System.Xml.Serialization.TypeMapping,System.String):this (FullOpts) 88 (5.03 % of base) : System.Private.DataContractSerialization.dasm - System.Xml.XmlBaseReader:AddXmlnsAttribute(System.Xml.XmlBaseReader+Namespace):System.Xml.XmlBaseReader+XmlAttributeNode:this (FullOpts) 84 (2.91 % of base) : System.Private.DataContractSerialization.dasm - System.Runtime.Serialization.Json.XmlJsonWriter:WriteStartAttribute(System.String,System.String,System.String):this (FullOpts) 80 (4.00 % of base) : System.Security.Cryptography.dasm - System.Security.Cryptography.X509Certificates.X509CertificateLoader:ProcessSafeContents(System.ReadOnlyMemory`1[ubyte],System.Security.Cryptography.X509Certificates.Pkcs12LoaderLimits,byref,byref) (FullOpts) 80 (2.84 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.Atom10FeedFormatter:ReadFeedFrom(System.Xml.XmlReader,System.ServiceModel.Syndication.SyndicationFeed,ubyte):System.ServiceModel.Syndication.SyndicationFeed:this (FullOpts) 80 (3.59 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.Atom10FeedFormatter:ReadItemFrom(System.Xml.XmlReader,System.ServiceModel.Syndication.SyndicationItem,System.Uri):this (FullOpts) 76 (19.59 % of base) : System.Net.Http.dasm - System.Net.Http.AuthenticationHelper:ProxySupportsConnectionAuth(System.Net.Http.HttpResponseMessage):ubyte (FullOpts) 76 (2.90 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.AtomPub10ServiceDocumentFormatter:ReadDocument(System.Xml.XmlReader):this (FullOpts) 76 (3.45 % of base) : System.ServiceModel.Syndication.dasm - System.ServiceModel.Syndication.AtomPub10ServiceDocumentFormatter:ReadWorkspace(System.Xml.XmlReader,System.ServiceModel.Syndication.ServiceDocument):System.ServiceModel.Syndication.Workspace:this (FullOpts) 76 (19.39 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.XmlQueryType:QNameToString(System.Xml.XmlQualifiedName):System.String (FullOpts) 76 (8.23 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.XsltOld.AttributeAction:CreateAttributeQName(System.String,System.String,System.Xml.Xsl.XsltOld.InputScopeManager):System.Xml.Xsl.XsltOld.PrefixQName (FullOpts) 72 (4.25 % of base) : System.CodeDom.dasm - Microsoft.CSharp.CSharpCodeGenerator:GenerateAttributes(System.CodeDom.CodeAttributeDeclarationCollection,System.String,ubyte):this (FullOpts) 72 (10.34 % of base) : System.Data.Common.dasm - System.Data.DataTable:IsEmptyXml(System.Xml.XmlReader):ubyte:this (FullOpts) 72 (2.60 % of base) : System.Private.Xml.dasm - System.Xml.Schema.SchemaCollectionPreprocessor:LoadExternals(System.Xml.Schema.XmlSchema,System.Xml.Schema.XmlSchemaCollection):this (FullOpts) 72 (4.43 % of base) : System.Private.Xml.dasm - System.Xml.Serialization.XmlSchemaImporter:FindDataType(System.Xml.XmlQualifiedName,int):System.Xml.Schema.XmlSchemaSimpleType:this (FullOpts) 72 (4.04 % of base) : System.Private.Xml.dasm - System.Xml.XmlWellFormedWriter:WriteStartAttributeAsync_NoAdvanceState(System.String,System.String,System.String):System.Threading.Tasks.Task:this (FullOpts) 68 (19.10 % of base) : System.Data.Odbc.dasm - System.Data.Odbc.TypeMap:FromDbType(int):System.Data.Odbc.TypeMap (FullOpts) 68 (7.17 % of base) : System.Data.Common.dasm - System.Data.XmlTreeGen:FindTypeNode(System.Xml.XmlElement,System.String):System.Xml.XmlElement (FullOpts) 68 (8.76 % of base) : System.Linq.Parallel.dasm - System.Linq.Parallel.SpoolingTask+<>c__DisplayClass0_0`2[double,System.Nullable`1[int]]:Artifacts: