search

Miista / pose

Replace any .NET method (including static and non-virtual) with a delegate
MIT License
27 stars 3 forks source link

Bring in changes from tonerdo/pose#62 #50

Open Miista opened 5 months ago

Miista commented 5 months ago

@stanimirsellercloud @stoyanov-x #29 is still open because support is not complete. As for #33 (this PR), it will be merged today. I just have to shuffle around the releases.

As for the changes in tonerdo/pose#74; they are already in this fork. There is explicit support for the following target frameworks:

Regarding tonerdo/pose#62 I am a bit unsure what it does and what is required by this fork. Perhaps you can elaborate in a new issue?

Originally posted by @Miista in https://github.com/Miista/pose/issues/33#issuecomment-2151524025

Miista commented 5 months ago

@stoyanov-x We can continue the discussion here :)

Miista commented 5 months ago

Perhaps @JTOne123 can shed some more light on this.

JTOne123 commented 4 months ago

Hi @Miista , I do know nothing about this project, sorry.

Miista commented 4 months ago

Hi @JTOne123, I mentioned you in this issue because I believe you are the author of the original PR here: https://github.com/tonerdo/pose/pull/62

Miista commented 4 months ago

@JTOne123 If this doesn't ring a bell, just let me know :)

JTOne123 commented 4 months ago

@Miista As I said I do know nothing about this proj and repo.

Miista commented 4 months ago

@JTOne123 Noted. Thank you! :)

@stoyanov-x Unless we can get more information about this I will close this issue.

Laniusexcubitor commented 2 months ago

What the mentioned PR does, is enable Sourcelink for the package, allowing easy debugging of the package. Just like sourcestepping for the .NET source code. With a correctly configured IDE, you can just step into the code of the library because it can automatically find the source on github.

But to be honest, if the PR author is not interested in this anymore I would ditch the PR ;)

Miista commented 2 months ago

@Laniusexcubitor I believe this should already be possible as I am including the debug symbols in the released package.

In any case I will close the issue as you suggested.

Laniusexcubitor commented 2 months ago

Seems the author used an automation tool to bulk create those pull requests in any repo found on nuget. So this wasn't tested anyway. Probably no problem for those changes. But that's what people always think, for "no brainer"-changes :)

If you have the symbols in the released package. Adding the Sourcelink.github package would help finding the sourcecode using those symbols. This enables auto download of the source files in the debugger. Putting the symbols in a separate snupkg, would enable on demand download of the symbols. But then the snupkg would need deployment to nuget.org alongside the nupkg.