Mijago / D2ArmorPicker

GNU Affero General Public License v3.0
135 stars 41 forks source link

Ability cool downs don't match in game cool downs #104

Open THATDONFC opened 1 year ago

THATDONFC commented 1 year ago

Cool down estimates in d2ap don't match the cool downs displayed in game across the different tiers.

Example: Warlock fusion grenade at Discipline T7 in game shows 0:52 and d2ap shows 0:40

I know there have been some buffs and nerfs to cool downs so I thought I'd create this issue to help keep track of the progress. I started converting some of the in-game cool downs to a ratio and will try to contribute to this if I'm able to make some time to work on it.

Mijago commented 1 year ago

If you want to tackle this, please take the Clarity repository into account: https://github.com/Database-Clarity/Character-Stats It'd be awesome if we could load their json and display the data right from there :)

E.g. we could create a ClarityInfoService, which loads (and caches!) the json. Afterwards it could serve the data to every other service that requests it.

Also see:

THATDONFC commented 1 year ago

I went through the ability cool downs and compared them to the numbers provided by the clarity repo. I updated the cool down scalars and adjusted some of the timers that have changed since Lightfall. I also added the new strand abilities and supers and adjusted the resilience scale.

I didn't have time to get into creating a json parser for the clarity info but I wanted to get the new info into d2ap sooner rather than later. I'll try to set some time aside this week to work on integrating the clarity data.

TheYeshir13 commented 1 year ago

I made a new issue for the clarity import #130 so we can theoretically close this one with the pull request

TheYeshir13 commented 1 year ago

The Season 21 Changes are not in the pull request

image