Closed KavinduDissanayake closed 6 months ago
@FulcrumOne any update on this issue? cc @alina-petrovska
@FulcrumOne Currently, i'm using your library for my project so waiting for your response. Thanks
@KavinduDissanayake, sorry but we have a lot of things to do at work. I'll back to you this weekend
No worries, Thanks for your response cc @FulcrumOne
Hey, @KavinduDissanayake
I'm not sure if I understood you correctly, but the first issue (with TabView button not responding) should be fixed with version 2.2.1.
As for the next ones - could you share some screenshots of the app so I can understand what the problems are? Thanks and have a great weekend!
@FulcrumOne Hi ,Just call your example project with below code , after that you can able see to with alert view bottom not will not dark .Currently Im using your library for my live project , that why it really hurry,Sorry for disturbing.
**@FulcrumOne
More info : `import SwiftUI
import MijickPopupView
struct ContentView: View { var body: some View { Button(action: { BottomPopup_Default().showAndStack() CentrePopup_UnlockNewFeatures().showAndStack()
}, label: {
/*@START_MENU_TOKEN@*/Text("Button")/*@END_MENU_TOKEN@*/
.alignHorizontally(.center)
})
}
}
ContentView()
}` **
@KavinduDissanayake, thanks, now I understand your point.
Unfortunately, when I designed the PopupView, the behaviour you described was not the expected one (I wanted to achieve that the popups of different types can be visible and clickable at the same time).
Nevertheless, I think that the change you requested is possible to achieve by modifying the PopupView
class from the library. I'll think how I can add this change to the whole system and get back to you.
@FulcrumOne Thank you so much
I double check every things , may be problem with area that allows for tap. without any modifier button tap work . But When I add any custom view. tap gesture again not work.
struct BreakDownBottomSheetView: BottomPopup {
// Adding a sample array of strings
func configurePopup(popup: BottomPopupConfig) -> BottomPopupConfig {
popup
.tapOutsideToDismiss(true)
.dragGestureEnabled(true)
.contentIgnoresSafeArea(true)
}
func createContent() -> some View {
VStack(spacing: 15){
TabView {
Button(action: {
print("Text Print")
/*Tap not working with appearance*/
}, label: {
/*@START_MENU_TOKEN@*/Text("Button")/*@END_MENU_TOKEN@*/
.alignHorizontally(.center)
.background(Color.green)
})
Text("First")
Text("Second")
Text("Third")
Text("Fourth")
}
.tabViewStyle(.page(indexDisplayMode: .never))
.indexViewStyle(PageIndexViewStyle(backgroundDisplayMode: .never))
.frame(height: 400)
.background(Color.red)
}
}
}
@FulcrumOne
// MARK: - Tapable Area
extension PopupStack {
@ViewBuilder func createTapArea() -> some View { if tapOutsideClosesPopup {
Color.black.opacity(0.44).ignoresSafeArea().onTapGesture(perform: items.last?.dismiss ?? {})
}}
}
When I adding this for your library Issue Number 02 resolved(Stack Popup outside not dark color issue), can you check the tap issues and update your pod with I given code is it possible ? cc @FulcrumOne
@FulcrumOne any update , sorry for disturbing
@KavinduDissanayake, sorry but I'm stuck at work. I'll try to update it this weekend
@FulcrumOne Any Update ?
@FulcrumOne any update on this issue?
@KavinduDissanayake requested feature was implemented in version 2.3.0
Issue Description
When attempting to
.showAndStack()
two separate center popups with custom views at the same time, the background view always adopts a gray color. This behavior occurs despite different configurations intended for the popups. Additionally, an issue with tap gestures is present when a bottom sheet with aTabView
is used; the button tap does not work upon the first appearance.Steps to Reproduce
.showAndStack()
with two separate center popups with custom views.TabView
.TabView
does not work on the first appearance.Expected Behavior
The background view should not default to gray when stacking popups, and all user interactions, such as tap gestures on buttons within a
TabView
, should be responsive upon the first appearance.Screenshots
iPhone 15 Example:
iPhone 15 Pro Example:
Screenshot of Issue:
Code Snippet