DismissAfter should be tied to a specific popup

Mijick / PopupView

Popups presentation made simple (SwiftUI)

MIT License

1.08k stars 42 forks source link

DismissAfter should be tied to a specific popup #86

Closed dejiphonebox closed 3 months ago

dejiphonebox commented 3 months ago

I am setting dismiss after 4 seconds for example. if the user manually dismisses the first notification and a second one is triggered, the first dismiss after 4 that was set on a previous notification seems to dismiss the current notification

FulcrumOne commented 3 months ago

hey @dejiphonebox,

A branch named "patch-2.3.1" should fix the issue above. Could you please check and confirm this?

Thanks and have a great evening! 😉

dejiphonebox commented 3 months ago

Sure! Taking a look now

dejiphonebox commented 3 months ago

Works as expected now 👌🏼

dejiphonebox commented 3 months ago

Reopened because I think I shouldn't mark this as closed. Bug is fixed however :)

FulcrumOne commented 3 months ago

glad to hear it! I'll clean up the solution a bit and merge with the main bit later.

thanks for help and don't hesitate to share any other bugs you notice! 😉