search

Mika56 / PHP-SPF-Check

Simple library to check an IP address against a domain's SPF record
MIT License
44 stars 25 forks source link

Two bugfixes for the DNSRecordGetterDirect class. #23

Closed hluaces closed 6 years ago

hluaces commented 6 years ago

First one: it is not properly using TCP when asked to do so. The reason is that it is not passing $this->udp to the DNSQuery.

Second: resolvePtr method is using the SPL implementation of dns_get_record instead of using the class' implementation.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 83.929% when pulling fb3e4e6f4434adba3da8b13f27b8c6f38e07b58d on hluaces:master into 744a81b0888d8133417df00a38fa20314ecb1902 on Mika56:master.

Mika56 commented 6 years ago

Looks good to me, tests are passing 👍

Mika56 commented 6 years ago

Released as v1.1.1