Made compatible and tested with Symfony 4.0

Mika56 / PHP-SPF-Check

Simple library to check an IP address against a domain's SPF record

MIT License

44 stars 25 forks source link

Made compatible and tested with Symfony 4.0 #27

Closed TheDevilOnLine closed 6 years ago

TheDevilOnLine commented 6 years ago

I've updated the composer json to match the requirements for Symfony 4.0 and ran PHPunit to verify it passes the tests. Please be so kind to merge my change and create a new tag (I'd suggest bumping to 2.0 since the minimal PHP version is also updated).

coveralls commented 6 years ago

Coverage decreased (-1.03%) to 82.985% when pulling befbec76971c3f88799b911964e1f0779c795116 on TheDevilOnLine:master into d5b0aa4fe98577751ccab9e6085f73bd28eccb75 on Mika56:master.

Mika56 commented 6 years ago

Hi,

It seems to me that we can allow Symfony 4 while keeping old PHP 5 compatibility:

Update the composer.json to revert the minimum PHP version. Each environnement will install either version 2, 3 or 4 of symfony/http-foundation depending on available PHP version and already installed symfony/http-foundation package.
Remove the composer.lock file so every tested version will resolve it's own compatible version of symfony/http-foundation
Update .travis.yml so composer command is update instead of install (line 23)

Tests should then work on every version.

TheDevilOnLine commented 6 years ago

The only way to do that (as far as I'm aware) is to remove the min php requirement, as it overwrites the actual PHP version for Composer. Therefore I couldn't install Symfony 4, unless I up'ed (or removed) the config.platform.php setting.

Mika56 commented 6 years ago

Hum, I wonder why that platform requirement is there. I remember putting it for a reason, but if all tests pass without it that's good to me

TheDevilOnLine commented 6 years ago

I've updated the PR to remove the composer.json and the PHP platform config. Currently Travis fails due to doctrine/instantiator, which requires PHP 7.1+, and is installed because of phpunit/phpunit 4.8.36

coveralls commented 6 years ago

Coverage remained the same at 84.01% when pulling 1715f3ff41074da38cad61871d2c371f08aa260c on TheDevilOnLine:master into d5b0aa4fe98577751ccab9e6085f73bd28eccb75 on Mika56:master.

Mika56 commented 6 years ago

I somehow had completely missed that you updated your PR as I had requested. Merging now, I'll publish a new release later tonight