search

MikaSchoenmakers / MikasBalatro

Collection of Mikas Balatro mods
GNU General Public License v3.0
16 stars 7 forks source link

Update for Customs Seals #5

Closed Cr4zZyBipBiip closed 5 months ago

Cr4zZyBipBiip commented 5 months ago

Added L.67-69 three config (false by default) for people using custom seal (Black, Green and Silver in this case) which add them on Commander Joker and HarpSeal (only black and Green, no need for silver one)

MikaSchoenmakers commented 5 months ago

Hey! I appreciate the help and I like the idea of supporting the custom seal mods that are out there. I just have 2 things to note.

Firstly, you're merging into the main branch, which is only for releases and critical bug fixes. I have a development branch for more in progress things.

Secondly, while I like the idea of supporting other seal mods, I think the current implementation is a bit flawed. I do not think most people will be changing anything in the config. I'll see if there is a way to check if other mods are active for support, and if there is a way to do that, I'll add your code to the mod :)

For now I'll close this, but I'll definitely keep it in mind for the future!

Cr4zZyBipBiip commented 5 months ago

Oh right, didn't see the development Branch No problem :) at least you have it somewhere if needed