search

MikaelGRA / InfluxDB.Client

InfluxDB Client for .NET
MIT License
102 stars 22 forks source link

Conversion to VS2017 project format & some changes from internal to public #13

Closed mkontula closed 7 years ago

mkontula commented 7 years ago

Authentication tests were randomly failing. Using a Task.Delay(200) after creation and dropping user solved the issue, but it's a bit flaky solution. Therefore the commit is marked as [NEEDS INVESTIGATION].

MikaelGRA commented 7 years ago

I will take a closer look at this tomorrow.

Probably going to change the setter of the "Series" property to private and add a constructor that takes a list instead.

MikaelGRA commented 7 years ago

Oh boy. It is all coming back to me now. The reason I was reluctant to upgrade to VS2017 is that I feel the tooling simply isn't there yet.

For example, I cannot seem to remove the package dependency on "NETStandard.Library" for the project, which includes a lot of unecessary dependencies.

Some links: https://developercommunity.visualstudio.com/content/problem/15372/cannot-remove-netstandardlibrary.html https://docs.microsoft.com/en-gb/dotnet/articles/core/deploying/reducing-dependencies https://github.com/dotnet/docs/issues/1745 https://docs.microsoft.com/en-us/dotnet/articles/core/tutorials/managing-package-dependency-versions

So I need to investigate whether or not this is even possible.

Alternative I could just remove all my other dependencies and keep the NETStandard.Library one. Would be easily done, but not necessarily pretty.

MikaelGRA commented 7 years ago

Update: After further investigation, you can add <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>

to the PropertyGroup in the csproj. This disables the SDK reference for 1.x.

mkontula commented 7 years ago

Most welcome! Waiting for the next package. Happy to help!