search

Mikata-Project / ggthemr

Themes for ggplot2.
886 stars 107 forks source link

geom_col: fill color not set #14

Closed czeildi closed 7 years ago

czeildi commented 7 years ago

with geom_col the fill color of the bars is not set to default palette color while with geom_bar it is.

ggthemr('flat')
ggplot(mtcars, aes(x = mpg, y = cyl)) +
    geom_col()
ggplot(mtcars, aes(x = mpg, y = cyl)) +
    geom_bar(stat = 'identity')
sainathadapa commented 7 years ago

Thanks for finding the issue! I have pushed a commit just now, which should solve this issue.

czeildi commented 7 years ago

super cool, perfect now!

czeildi commented 7 years ago

Hi, probably similar, but I am not 100% sure: geom ribbon is a generalization of geom area, and I would expect to geom_vline behave the same as geom_hline.

sainathadapa commented 7 years ago

Thanks! corrected now.

czeildi commented 7 years ago

thanks! btw cool package, I am currently working on a custom palette + theme using ggthemr.

sainathadapa commented 7 years ago

I'm just maintaining the package currently. @cttobin is the author, who wrote most of the code.