search

Mikata-Project / ggthemr

Themes for ggplot2.
886 stars 107 forks source link

Default colour scales fix #52

Closed Matt-Int closed 2 years ago

Matt-Int commented 2 years ago

I've finally had a chance to look at this issue in more depth, and tracked down the root of the issue: ggplot2 options only seem to use the British spelling when using the colour options. Thanks to @lotard with their tidyverse/ggplot2#4626 issue which pointed me in the right direction.

This fixes #44. And as such should hopefully open this up to a CRAN release at some point.

tfrayner commented 2 years ago

In case it helps expedite the merge, I can confirm this fixes the issue for both R versions 4.0 and 4.1.

Matt-Int commented 2 years ago

After testing, this also fixes #54

Matt-Int commented 2 years ago

@amy17519 @daroczig Any chance of getting this pull request merged into the main branch?

daroczig commented 2 years ago

Oh, sorry for the delay -- thanks a lot for tracking this down and the related work :tada: