search

Mike-Gibson / mock-apollo-client

Helps unit test components which use the Apollo Client.
MIT License
117 stars 15 forks source link

Update mockLink.ts #54

Closed sailod closed 7 months ago

sailod commented 1 year ago

make it more clear where the variable is coming from

Mike-Gibson commented 1 year ago

Hi, thanks for contributing. Could you please explain further what you're trying to achieve with this PR?

sailod commented 1 year ago

To make the call more explicit, using this helps understand better where it comes from

On Tue, Sep 5, 2023, 13:58 Mike-Gibson @.***> wrote:

Hi, thanks for controbuting. Could you please explain further what you're trying to achieve with this PR?

— Reply to this email directly, view it on GitHub https://github.com/Mike-Gibson/mock-apollo-client/pull/54#issuecomment-1706050298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJPXXETSM5WI2SBDMS5KJ5DXY3ESBANCNFSM6AAAAAA4LG7VJY . You are receiving this because you authored the thread.Message ID: @.***>

Mike-Gibson commented 1 year ago

Apologies @sailod , but I still don't understand how this change could make it 'more explicit'. And I'm not sure what you are referring to when you say 'better where it comes from'. Could you give an example of what is more explicit/better to understand after the change? Is it something to do with debugging, stack straces, or just code readability?

I can see the build is failing as the change has introduced a syntax error.

Mike-Gibson commented 7 months ago

I'm going to close this as there hasn't been a reply. Feel free to add more info and we can re-open.