Mike-Heneghan / ALISS

ALISS (A Local Information System for Scotland) is a service to help you find help and support close to you when you need it most.
https://aliss.org
0 stars 0 forks source link

Remove local authority data which isn't for scotland. #127

Closed Mike-Heneghan closed 5 years ago

Mike-Heneghan commented 5 years ago

It was decided to move to the clipped local authority geospatial data to improve load times.

It was known that the smaller size data set also included local authorities outside of Scotland although it was not realised at the time that these would also be rendered on the service area explanation page as below:

Screenshot 2019-11-22 at 17 36 06

This could be misleading as it may make it appear that ALISS supports England N.I. and Wales.

Mike-Heneghan commented 5 years ago

Updated the JS to check that features in the local authority data set have a code starting with "S" ensuring they are Scottish areas. The solution does work although it's not very maintainable.

It could potentially be better to remove the features which aren't in Scotland.

Although in situations where users add locations to a service which are outside the UK it can be useful to know where that is.

I think this could be worth revisiting.

Mike-Heneghan commented 5 years ago
Screenshot 2019-11-28 at 15 18 28
Mike-Heneghan commented 5 years ago

merged