Improve usability "Remove Location" button for service. - Githubissues

Mike-Heneghan / ALISS

ALISS (A Local Information System for Scotland) is a service to help you find help and support close to you when you need it most.

https://aliss.org

0 stars 0 forks source link

Improve usability "Remove Location" button for service. #68

Closed Mike-Heneghan closed 5 years ago

Mike-Heneghan commented 5 years ago

Currently is a user wants to remove a location from their service they are likely to try to do this by selecting "Delete Location":

Screenshot 2019-03-22 at 17 21 06

If the location is also associated with other services a warning appears.

Screenshot 2019-03-26 at 10 40 00

As a usability improvement, it would be useful to change the language and behaviour to 'Remove Location' which would delete the join between the service and location rather than the location itself.

Mike-Heneghan commented 5 years ago

To do list:

[x] Write a method to delete the join between an individual service and a location.
[x] Test the method in the shell.
[ ] ~Update the service detail to use the new method and change the working to 'Remove Location'.~

Mike-Heneghan commented 5 years ago

Trying to add "Remove Location" button to the location/detail.html partial has been problematic. It might be better to use a different to allow easier handling of the methods.

Mike-Heneghan commented 5 years ago

As Services are indexed in Elasticsearch and the button would be on the Locations detail page I think it would be best if the location/detail.html partial was not used as this causes issues with passing variables. After deleting the join between the selected Location and Service the service should be saved.

Mike-Heneghan commented 5 years ago

To do list:

[x] Update the Service Detail to remove the location/detail.html partial.
[ ] ~Use Digest delete example to show means of deleting a join.~
[ ] Test the new feature to ensure Service records are updated successfully.

Mike-Heneghan commented 5 years ago

The rather than DeleteView I think the UpdateView would be a better generic view for handling this feature.

Mike-Heneghan commented 5 years ago

Although the functionality is implemented it is not necessarily following best practices of a DeleteView. Need to refactor to improve.

Mike-Heneghan commented 5 years ago

Need to fix formatting:

Mike-Heneghan commented 5 years ago

To do list:

[x] Test the view.
[x] Fix the alignment of the "Remove location" button. (Needs to be done properly)

Mike-Heneghan commented 5 years ago

For the formatting it would be easiest to change the "Remove location" button to an anchor but, it doesn't seem like good practice / possible to submit the form using an anchor tag without JS.

From the chrome dev tools, a margin-top: 0.5 rem is applied to buttons. Can't seem to override it without inline styling.

Mike-Heneghan commented 5 years ago

Merged into master