Landing Pages

[Mike-Heneghan]

We are going to have landing pages which combine a location and category. places/aberdeen/mental-health.

Landing page view. It'll take a place name and a category URL and do the search.

Need a slug based on a place name which may not be allowed to be null. Instead, make a postcode slug.

Slug fields are generated from another field need to read the docs.

To start with category pre-selected will be a piece of copy at the top of the search page.

Create the view and confirm that things are working by adding a placeholder page.

[Mike-Heneghan]

To do list:

• [x] Need to add a slug for place names which would be added to postcodes. If the slug is not allowed to be null then it should be set as the postcode. Need to research https://docs.djangoproject.com/en/1.11/ref/models/fields/.
• [x] Add a new view for the landing page to generate the copy from the place name and category.

[Mike-Heneghan]

Although there is a SlugField for both the Organisation and Service models a field slug is a CharField. This starts blank and a method generate_slug is called to populate it based on the name.

I think it would be best to research with the intention of using a built in SlugField if it reduces complexity.

[Mike-Heneghan]

https://stackoverflow.com/questions/837828/how-do-i-create-a-slug-in-django

It seems like there are a few different ways to assign slugs. As per the above link, we could overwrite the save method and slugify the place-name. Although I'm unsure as to whether we'd need a way triggering a save on all postcode records for this to take effect?

def save(self, *args, **kwargs):
  self.slug = slugify(self.place_name)
  super(Test, self).save(*args, **kwargs)

Although this doesn't seem to be very different from the example of Organisation and Service models slug generation.

[Mike-Heneghan]

As per discussion need to handle situations where a place name needs to be distinguished from another using a region i.e.

'Westhill, Aberdeenshire', 'Westhill, Highland' or 'Blackburn, Aberdeenshire', 'Blackburn, West Lothian' ' Going to leave the edge cases of locations with more than one instance until later.

[Mike-Heneghan]

Went down a rabbit hole of default methods but confirmed a model cannot have a field which points to another field in the same instance on creation.

Steps which were taken:

• Made migration to create the slug field with a default of 'none' as it cannot be null.
• In the shell imported create_place_name_slugs and passed force=True.
• In the shell iterated through 15+k records and updated the slug field based on a place_name where possible and a postcode otherwise.

My local DB now has slug fields with place_names.

[Mike-Heneghan]

Now when we pass the url /places/aberdeen/goods the <place_slug>/<category_slug> are used to redirect to the search results.

We need to add more sophisticated behaviour to reuse the majority of the search/results.html with the addition of summary text for the result.

To do list:

• [x] Move the appropriate result.html code into a partial.
• [x] Point the places view at place/result.html
• [x] Update the category.html partial to update the syntax for query_transform.
• [x] Updated all instances of query_transform with the new root='' syntax.
• [x] Updated the partials which use query_transform to provide a root.
• [x] Fix the redirect to the search page from the places page.
• [x] Move the appropriate result.html js into somewhere it can be accessed.
• [x] Handle custom range in places/ (Had to hide)
• [x] Handle keyword search redirect to search page.
• [x] Add necessary methods to handle giving the objects to the template from the view.

[Mike-Heneghan]

Need to check the behaviour and make sure I'm using best practices.

[Mike-Heneghan]

Need to add tests for new 'places' view.

• [x] Add basic status_code = 200 tests.
• [x] Check responses contain what we expect.
• [x] Test error handling.
• [ ] ~Test redirects work from places to search (filter options)~
• [x] Test filter links are the correct path i.e. /search (indirect query_transform test)

[Mike-Heneghan]

Need to make sure the view is handling errors with both place names and categories.

[Mike-Heneghan]

Information on templatetag testing:

• https://krzysztofzuraw.com/blog/2017/how-to-test-django-template-tags.html

[Mike-Heneghan]

The only non-ideal behaviour for the places/ result page is the category link does redirect to search but the category isn't updated.

Updated the aliss.js query_transform method to only create category key if it isn't there already.

[Mike-Heneghan]

The pagination for /places is problematic as it redirects to /search need to sort in query_transform.

[Mike-Heneghan]

Might be worth rolling back the migration for the postcode field and try reapplying.

generate_place_name_slugs() as the method has been changed since it was applied.

[Mike-Heneghan]

Need to update the query_transform method to reduce DB operations and increase reliability by using context data.

• [ ] Allow context data to be accessed in templatetag.
• [ ] Update the method to use postcode and category objects.

[Mike-Heneghan]

Merged into master