Mike-Heneghan / ALISS

ALISS (A Local Information System for Scotland) is a service to help you find help and support close to you when you need it most.
https://aliss.org
0 stars 0 forks source link

Password reset email may be case sensitive #86

Closed Mike-Heneghan closed 4 years ago

Mike-Heneghan commented 4 years ago

Investigate and fix

Mike-Heneghan commented 4 years ago

If a user tries to reset their password and they have the wrong case for their email they will be sent a recovery password for their account. Although that email will be sent as per the incorrect case email submitted.

For example:

From googling, it looks like emails are case sensitive but a lot of email providers support your email address with all its different cases. https://www.lifewire.com/are-email-addresses-case-sensitive-1171111

So I believe this means that if a user uses the wrong case on their email for a password reset it should still be delivered to them.

It also appears that user login is case sensitive which may partially due to security. I think Django as standard follows the standard stating emails should be case sensitive.

Mike-Heneghan commented 4 years ago

The account signup is not case sensitive and would therefore not allow a new user to be created with B5249588@urhen.com if a user with b5249588@urhen.com already exists.

Screenshot 2019-07-25 at 16 55 51
Mike-Heneghan commented 4 years ago

https://webmasters.stackexchange.com/questions/34056/is-it-ok-to-use-uppercase-letters-in-an-email-address/34058

Mike-Heneghan commented 4 years ago

As the project already seems to follow best practices in regard to email case sensitivity the best option could be to better educate the user. This could involve:

Mike-Heneghan commented 4 years ago

Merged into master