Orientation / Rotation EXIF metadata seemingly not used

MikeGawi / ePiframe

ePiframe is an e-Paper (or HDMI, Composite display) Raspberry Pi Photo Frame with Google Photos and more

GNU General Public License v3.0

63 stars 10 forks source link

Orientation / Rotation EXIF metadata seemingly not used #62

Closed jakemauer closed 2 years ago

jakemauer commented 2 years ago

Hi Mike!

First let me say THANK YOU for writing and maintaining a photo frame app that actually works on first install and has a decent webUI.

I have the ePiframe running on a pi4 b and I'm trying it out using some photos that I copied directly to an album folder in the photos folder in the ePiframe directory on the pi. The images show up! However for vertically shot photos that have EXIF orientations of say 6 (rotated 90º counterclockwise), they display un-rotated on my screen.

So this image:

Renders like this on my photo frame's display:

Obviously I can fix the EXIF data, but I would love to be able to drag and drop photos into that folder without preprocessing. Is there an obvious setting or fix that I'm missing?

Thank you again!

MikeGawi commented 2 years ago

Thanks for bringing that up! To be honest, I've completely forgot about this information stored in EXIF data and it seems obvious and reasonable to use it as a rotation value for photos (maybe as an option in settings to use EXIF or fixed rotation). I will implement that, especially when ImageMagick used by this project has a possibility to easily extract the data. Thanks!

First let me say THANK YOU for writing and maintaining a photo frame app that actually works on first install and has a decent webUI.

Thank YOU for the kind words, that really means a lot for me and keeps me going.

MikeGawi commented 2 years ago

All examples of EXIF orientations can be found here. The data can be extracted by ImageMagick with this solution.

MikeGawi commented 2 years ago

It is easier than I thought: I will use -auto-orient option of ImageMagick.

MikeGawi commented 2 years ago

Done. Few remarks:

ImageMagick will automatically orientate photo according to EXIF data
Auto-orient takes time, so due to compatibility with Pi Zero option is disabled by default in the configuration (enable by setting auto_orientation=1 in config.cfg or enable Auto Orientation in UI Settings->Image)
Auto-orient takes time even if EXIF information is missing (!), so a small optimization was added, i.e. the code checks for EXIF first before executing Auto-orient

Please check this solution and leave a feedback or reopen the issue. Cheers!

jakemauer commented 2 years ago

WOW Mike!! This was so fast. Thank you!