search

MikeInnes / Charlotte.jl

Charlotte's Web Scale
Other
113 stars 13 forks source link

Added relu example as test #16

Closed sjorn3 closed 6 years ago

sjorn3 commented 6 years ago

Currently implemented on top of the working commit to show function, will rebase on top of master once ready.

If there's a cleaner way of comparing the expected/result values let me know.

tshort commented 6 years ago

Looks fine to me. We need a better overall approach to tests, but this is fine for now.

sjorn3 commented 6 years ago

It seems the easiest way to get the macro working again is to add an empty ModuleState() to the code_wasm call. It's unclear to me how you'd go about including proper module information in a macro such as this one anyway.

I've rebased on top of master and as long as it's good I think this should be merged soon.

tshort commented 6 years ago

The empty ModuleState() is the way to go. @code_wasm is only really useful for the REPL. wasm_module is more useful because it generates a module that you can write to a wast/wasm file.