search

MikeInnes / Lazy.jl

I was gonna maintain this package, but then I got high
Other
470 stars 54 forks source link

Work around removal of Base.Predicate #58

Closed ararslan closed 7 years ago

ararslan commented 7 years ago

Fixes #57

The Predicate wrapper for functions was removed from Base yesterday. Since this package depends on it, the package is failing on nightly. This PR simply copies the definition that was in Base into this package. It would be great if you could tag a release after this is merged so that the packages that depend on this won't also fail.

MikeInnes commented 7 years ago

Thanks for the patch, but if Predicate is no longer meaningful I think it'd be better to just remove references to it. It's only used in any and all to mirror Base's versions of those functions, so presumably we can make the same change that Base did (just remove the type annotation perhaps?).

ararslan commented 7 years ago

That sounds like an even better idea, I'll try that. Thanks Mike!

MikeInnes commented 7 years ago

Thanks!

mlubin commented 7 years ago

Could we get a new tagged release so that we can try to get JuMP passing on master?

mlubin commented 7 years ago

Gentle bump

dpo commented 7 years ago

Another gentle bump.

MikeInnes commented 7 years ago

Didn't this happen with 0.11.5?

dpo commented 7 years ago

Ah I see, sorry. Some package in my dependency tree is still requiring Lazy 0.11.4. Thanks.

tkelman commented 7 years ago

This introduced ambiguity warnings on 0.4, and possibly ambiguity traps that would be errors on 0.5.

tkelman commented 7 years ago

ping @ararslan something should be done about that, introducing a lot of warnings on an existing Julia release version is not good

ararslan commented 7 years ago

@tkelman Sorry for the delay, I've been busy and this slipped through the cracks. I'll look into it.