fix `@init` macro in light of new macro scoping rules in 0.7

MikeInnes / Lazy.jl

I was gonna maintain this package, but then I got high

Other

470 stars 54 forks source link

fix `@init` macro in light of new macro scoping rules in 0.7 #72

Closed marius311 closed 6 years ago

marius311 commented 6 years ago

The @init macro doesn't work as-is on 0.7 master because the scoping/escaping rules changed (I think due to https://github.com/JuliaLang/julia/pull/22985, see also https://github.com/JuliaLang/julia/issues/23221). Also, isdefined is deprecated. This fixes all of these things in the best (only?) way I could thing of that works on both 0.6 and 0.7 with no depwarns.

MikeInnes commented 6 years ago

Thanks! looks like this still fails on 0.7, or is that a separate issue that just isn't addressed here?

marius311 commented 6 years ago

That's a separate issue, but which I think is fixed by https://github.com/JobJob/Lazy.jl/commit/8ed259c2dc4c83701fefd904378dfd0055075a75

At the time, if I merged that commit into the one from this PR, I was able to do an error free using Lazy on Julia master, so I think that's a good place to start if you wanted to get this working now. Of course, its possible stuff on master in last two weeks has broken additional things.

MikeInnes commented 6 years ago

Seems good to me. Thanks!