search

MikeKovarik / gulp-better-rollup

📦 Better Gulp plugin for Rollup ES6 module bundler
MIT License
49 stars 16 forks source link

Fatal error when using moduleId option #13

Closed piotr-cz closed 6 years ago

piotr-cz commented 6 years ago

In v2 when using the moduleId option, rollup fails to build:

events.js:160
      throw er; // Unhandled 'error' event
      ^
Error: Cannot have both options.amd and options.moduleId

as the amd option is automatically added by gulp-better-rollup.

MikeKovarik commented 6 years ago

Not sure if the latest update helps but check it out. It changes in how the options object is desugared down to rollup's inputOptions & outputOptions. If the problem persists I'd suggest using the two-settings-object way explicitly.

piotr-cz commented 6 years ago

I've updated to latest version, adjusted renamed rollup options and it works now. BTW: I've been using two-settings-object.

Thank you!