search

MikeKovarik / gulp-better-rollup

📦 Better Gulp plugin for Rollup ES6 module bundler
MIT License
49 stars 16 forks source link

Rollup 2 support #45

Closed eshimischi closed 1 year ago

eshimischi commented 4 years ago

Any plans on updating your library to Rollup 2 ?

duzun commented 3 years ago

I'm using rollup@2 with this lib for a while now and it works great. Related #48

Honatas commented 3 years ago

This gulp plugin works 100% with version 2 of Rollup. The problem is, with npm version 7 the build is breaking:

npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: myproject@1.0.0 npm ERR! Found: rollup@1.32.1 npm ERR! node_modules/rollup npm ERR! dev rollup@"^1.32.1" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer rollup@"^2.14.0" from @rollup/plugin-typescript@6.1.0 npm ERR! node_modules/@rollup/plugin-typescript npm ERR! dev @rollup/plugin-typescript@"^6.1.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force, or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@duzun 's #48 pull request fixes this problem.

@MikeKovarik can you please accept the PR? Or else we'll have to either keep using the --legacy-peer-deps flag or revert to using npm 6.

massadm commented 1 year ago

As of npm cli v8.3.0 (2021-12-09) this can be solved using the overrides field of your package.json.

"overrides": {
  "gulp-better-rollup": {
    "rollup": "^1||^2||^3"
  }
}
Zardoz89 commented 1 year ago

@massadm Try to use https://github.com/tborychowski/gulp-rollup-plugin as it's a updated and maintained fork, instead using workaround with a gulp plugin that has been updated in years.