search

MikeKovarik / rollup-plugin-notify

📟 Displays rollup errors as system notifications.
MIT License
19 stars 5 forks source link

allow configuration of success message #6

Closed rob-marr closed 5 years ago

rob-marr commented 5 years ago

I'm running multiple concurrent rollup builds so needed a custom success message to know which one is finished.

MikeKovarik commented 5 years ago

Hey, thanks for the PR. I'm sorry, i didn't notice this was a PR, I only saw email title and thought it's another issue so i quickly put together options.id in the commit i pushed a minute ago. Would you try that and see if it works for you? thanks

rob-marr commented 5 years ago

No worries, I like your solution better than mine anyway, mine didn't tell you which build was failing 🤦🏻‍♂️ and it works fine:

Screen Shot 2019-09-07 at 13 34 35
MikeKovarik commented 5 years ago

Great, so I'll publish it on npm if there's nothing more to implement.

rob-marr commented 5 years ago

you could still add the changes that allow config of the message but It doesn't seem to useful now, just a nice to have