search

MikeMcl / bignumber.js

A JavaScript library for arbitrary-precision decimal and non-decimal arithmetic
http://mikemcl.github.io/bignumber.js
MIT License
6.69k stars 742 forks source link

Add LGTM code quality badges #191

Closed xcorail closed 6 years ago

xcorail commented 6 years ago

Hi there!

I thought you might be interested in adding these code quality badges to your project. They will indicate a very high code quality to potential users and contributors. To get an idea of the analyses reflected by these grades, check the alerts discovered by LGTM.

N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

MikeMcl commented 6 years ago

I've taken a look and lgtm.com is impressive. I noticed that many of the alerts for this library relate to the BigDecimal-all-last.js file which is another library only included here for a performance comparison test - it's code quality is nothing to do with this project.

xcorail commented 6 years ago

Hello @MikeMcl

Happy you found it impressive. In this case, even if you don't put the badges, the alerts will be always available for you. Our recommended usage is to activate LGTM automated code review. LGTM will analyse and comment directly your Pull requests. This is a one click operation, and still free for open source projects.

Do you want me to propose a PR to classify BigDecimal-all-last.js as external library? This will automatically exclude these unwanted alerts.

MikeMcl commented 6 years ago

Do you want me to propose a PR to classify BigDecimal-all-last.js as external library?

Yes, and preferably the whole perf folder.